-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming convention for test classes #552
Comments
I would add the singular |
At least for me Gradle does not seem to execute the test class when its name ends with |
@Bukama the test isn't executed via Gradle: As you can see, |
I'd rather live with the rare case that a class called What about inner classes that we execute manually, though? They're usually (always) called (Tip for the implementor: I couldn't immediately find these classes in the open type dialog and instead of thinking about the problem or looking for some check box to tick, I did a full text search for "TestCase(s).class".) |
During our preparations for Pioneer 1.0 release we discussed about naming conventions for almost all of our classes etc (see #215 ). But we didn't talked about naming test classes.
@Marcono1234 revealed in #543 that currently test classes must (^1) end with
Tests
(plural) to be picked up by the correspondending Gradle action. This issue extracts his question if we shoul also allow the singular variantTest
which is frequently used by programmers.The maven surefire and failsafe plugin pick up both
Test
andTests
classes by default.What confuses me is: Are classes which ends on
Test
are really not picked up? We have:the AbstractEntryBasedExtensionTest class and I'm quite sure it is picked up (as it sometimes fails). This test is renamed in the PR too to match the naming conventions
The text was updated successfully, but these errors were encountered: