Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JUnit to 5.8 #594

Closed
nipafx opened this issue Feb 17, 2022 · 0 comments · Fixed by #612
Closed

Update JUnit to 5.8 #594

nipafx opened this issue Feb 17, 2022 · 0 comments · Fixed by #612
Assignees
@Bukama
Labels
good first issue 📖 theme: build 🏗️ type: enhancement 📢 up for grabs 🛸 3rd-party: Github Actions
Projects
Exploring Io

Comments

@nipafx
Copy link
Member

nipafx commented Feb 17, 2022 •
edited

The temporary directory/resource extension proposed in #348 / #491 requires parameter-level extension registration, which was added in JUnit Jupiter 5.8.0. Updating from 5.7 to 5.8 requires no code changes.

As per contribution guidelines, this update should be done in a separate issue (this one) and PR (to be opened). If no other features requires 5.8 before #348, a PR can be proposed and merged right before #491 is merged - use the following commit message (add correct PR number in header and body):

Update JUnit to 5.8 (#594 / #XYZ)

The temporary directory/resource extension proposed in #348 / #491
requires parameter-level extension registration, which was added in
JUnit Jupiter 5.8.0[1].

[1]: https://junit.org/junit5/docs/5.8.0/release-notes/index.html

Closes: #594
PR: #XYZ
@nipafx nipafx mentioned this issue Feb 17, 2022
Merged
13 tasks
@Michael1993 Michael1993 added this to To do in Exploring Io Feb 22, 2022
@Bukama Bukama self-assigned this Mar 24, 2022
Bukama added a commit to Bukama/junit-pioneer that referenced this issue Mar 27, 2022
@Bukama
Update JUnit to 5.8 (junit-pioneer#594 / junit-pioneer#612)
7158bc8 
The temporary directory/resource extension proposed in junit-pioneer#348 / junit-pioneer#491
requires parameter-level extension registration, which was added in
JUnit Jupiter 5.8.0[1].

[1]: https://junit.org/junit5/docs/5.8.0/release-notes/index.html

Closes: junit-pioneer#594
PR: junit-pioneer#612
@Bukama Bukama mentioned this issue Mar 27, 2022
Merged
@Bukama Bukama moved this from To do to In progress in Exploring Io Mar 27, 2022
Exploring Io automation moved this from In progress to Done Mar 31, 2022
Bukama added a commit that referenced this issue Mar 31, 2022
@Bukama
Update JUnit to 5.8 (#594 / #612)
ecb726c 
The temporary directory/resource extension proposed in #348 / #491
requires parameter-level extension registration, which was added in
JUnit Jupiter 5.8.0[1].

[1]: https://junit.org/junit5/docs/5.8.0/release-notes/index.html

Closes: #594
PR: #612
@beatngu13 beatngu13 mentioned this issue Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bukama Bukama

Labels
good first issue 📖 theme: build 🏗️ type: enhancement 📢 up for grabs 🛸 3rd-party: Github Actions
Projects
No open projects
Exploring Io
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JUnit to 5.8 (#594 / #612) Bukama/junit-pioneer
2 participants
@Bukama @nipafx