Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions #185

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Github actions #185

merged 1 commit into from
Mar 26, 2020

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Mar 17, 2020

This is just a draft and a simple idea for now

the build steps are working, it uploads to sonarqube, and it triggers correctly the build. i need to verify the deploy (or depoy :)) step, as there is a lot going on, i am not aware of, or have not tried so far. But i thought this might be useful.

Any ideas welcome

image


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

.github/workflows/actions.yml Outdated Show resolved Hide resolved
@Bukama
Copy link
Member

Bukama commented Mar 18, 2020

Maybe @sormuras can throw an eye on it - When I remember correctly he set up the github actions for Junit but at least for his BACH project

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the .yml files and commented inline.

strategy:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
java: [ 8, 9, 10, 11, 12, 13]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only keep: 8, 11, and introduce 14 as of today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
java: [ 8, 9, 10, 11, 12, 13]
java: [ 8, 11, 14]

if: matrix.java == '8' && matrix.os == 'ubuntu-latest'
run: ./gradlew jacocoTestReport sonarqube --stacktrace -i

depoy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy, with l

@aepfli
Copy link
Member Author

aepfli commented Mar 19, 2020

i am really thinking of dropping my Travis CI pr instead of this, this seems to be way easier, as nearly all configuration is takin gplace in github

  1. https://github.com/junit-pioneer/junit-pioneer/actions we need to create an action here
  2. we would need to provide the sonar token for the project in https://github.com/junit-pioneer/junit-pioneer/settings/secrets

and we would be done, this would be working

  1. i would still remove the deployment steps for now in Github Actions as this needs more attention
  2. furthermore i would deactivate the default builds in travis.yml so we do not use so many resources.

Thoughts?
@Bukama @nicolaiparlog

@Bukama
Copy link
Member

Bukama commented Mar 20, 2020

I appreciate dropping a "3rd party" tool for better / easier integration with the plattform we already use as long as the provided functionality stays the same. This seems to be the case here.

So I would vote for building up GitHub actions parallel to Travis- When the new script works we should disable Travis and after a (short) period of time dropping this back up scenario in total.

@aepfli
Copy link
Member Author

aepfli commented Mar 22, 2020

i created an own example project with the setup :) aepfli/SonarCloud-GitHubActions-Gradle-example#2 there we see all functionality and basic configuration needed

As Github offers now its own CI Tool with GithubActions,
we want to migrate to this new approach, as it is tightly
coupled with github anyway.

Sonarqube injects its proeprties already correctly, so it
should be fine to use.

We only have to add the SONAR_TOKEN to the project secrets,
but that is nothing i can do.

Issue: junit-pioneer#192
@@ -18,8 +17,8 @@ install: ./gradlew -version

#Don't build tags
branches:
except:
- /^v\d/
only:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we will have githubactions for normal builds, we we only need this for the special case of "deployments" which should only happen on master

@aepfli aepfli marked this pull request as ready for review March 26, 2020 21:34
@aepfli aepfli changed the title [DRAFT] github actions Github actions Mar 26, 2020
@nipafx nipafx merged commit 4f3647f into junit-pioneer:master Mar 26, 2020
@aepfli aepfli deleted the issues/githubActions branch May 31, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants