-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions #185
Github actions #185
Conversation
Maybe @sormuras can throw an eye on it - When I remember correctly he set up the github actions for Junit but at least for his BACH project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed the .yml
files and commented inline.
.github/workflows/actions.yml
Outdated
strategy: | ||
matrix: | ||
# test against latest update of each major Java version, as well as specific updates of LTS versions: | ||
java: [ 8, 9, 10, 11, 12, 13] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd only keep: 8
, 11
, and introduce 14
as of today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java: [ 8, 9, 10, 11, 12, 13] | |
java: [ 8, 11, 14] |
.github/workflows/actions.yml
Outdated
if: matrix.java == '8' && matrix.os == 'ubuntu-latest' | ||
run: ./gradlew jacocoTestReport sonarqube --stacktrace -i | ||
|
||
depoy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy
, with l
12f7270
to
22632b8
Compare
i am really thinking of dropping my Travis CI pr instead of this, this seems to be way easier, as nearly all configuration is takin gplace in github
and we would be done, this would be working
Thoughts? |
I appreciate dropping a "3rd party" tool for better / easier integration with the plattform we already use as long as the provided functionality stays the same. This seems to be the case here. So I would vote for building up GitHub actions parallel to Travis- When the new script works we should disable Travis and after a (short) period of time dropping this back up scenario in total. |
i created an own example project with the setup :) aepfli/SonarCloud-GitHubActions-Gradle-example#2 there we see all functionality and basic configuration needed |
As Github offers now its own CI Tool with GithubActions, we want to migrate to this new approach, as it is tightly coupled with github anyway. Sonarqube injects its proeprties already correctly, so it should be fine to use. We only have to add the SONAR_TOKEN to the project secrets, but that is nothing i can do. Issue: junit-pioneer#192
975869d
to
cb88030
Compare
@@ -18,8 +17,8 @@ install: ./gradlew -version | |||
|
|||
#Don't build tags | |||
branches: | |||
except: | |||
- /^v\d/ | |||
only: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we will have githubactions for normal builds, we we only need this for the special case of "deployments" which should only happen on master
This is just a draft and a simple idea for now
the build steps are working, it uploads to sonarqube, and it triggers correctly the build. i need to verify the deploy (or depoy :)) step, as there is a lot going on, i am not aware of, or have not tried so far. But i thought this might be useful.
Any ideas welcome
I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.