Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle improvements #220

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Apr 5, 2020

Removing limitation of checkstyle to just check
production code. Adding package info for successful run.

Issue: #219


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Removing limitation of checkstyle to just check
production code. Added suppressions exception for
test code, for package info

Issues: junit-pioneer#219
Closes: junit-pioneer#219
@aepfli aepfli force-pushed the issues/219-Checkstyle-improvements branch from eb125cb to 5f709df Compare April 6, 2020 08:55
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aepfli aepfli marked this pull request as ready for review April 6, 2020 11:20
@nipafx
Copy link
Member

nipafx commented Apr 7, 2020

As discussed in #219, we don't have to look at the specific checks. Just rebase on master and once the build is successful, we can merge and then fiddle with the rules later.

@Bukama
Copy link
Member

Bukama commented Apr 8, 2020

I approve this PR to get the improvements from this and to close #219.

Further discussion about the specific rules shall be done in #217.

@nipafx nipafx merged commit 859f712 into junit-pioneer:master Apr 21, 2020
@aepfli aepfli deleted the issues/219-Checkstyle-improvements branch May 31, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants