Added variables to ReportEntry #294
Conversation
Refer to test method arguments with numbers between curly braces, starting with {0}.
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
|
Progresses (possibly will close) #179 |
|
I like the change and I appreciate that the syntax aligns with Jupiter's parameter-in-display-name syntax. Unfortunately, the documentation didn't get updated yet and so we can't merge this. Quoting @aepfli and @Bukama "DENIED" "NEXT!" 😜 |
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
… into issue/179-report-entry-improvement � Conflicts: � src/test/java/org/junitpioneer/jupiter/ReportEntryExtensionTests.java
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
src/main/java/org/junitpioneer/jupiter/ReportEntryExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/ReportEntryExtension.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
docs/report-entries.adoc
Outdated
|
|
||
| You can access `@ParameterizedTest` parameter values and publish them with the `@ReportEntry` annotation. | ||
| Add a number (starting from zero) between curly braces to reference the parameter with that index. |
There was a problem hiding this comment.
Can you mention and link to the format you're using here? (Is it String::format or MessageFormat?)
There was a problem hiding this comment.
As far as I see - this is still open right?
There was a problem hiding this comment.
Did I misunderstand? I did mention that the format of the variables is in line with JUnit's @ParameterizedTest naming
There was a problem hiding this comment.
The way I understood Nicolais question is that he wanted to see you mention String::format or MessageFormat, but maybe I missunderstood him.
src/main/java/org/junitpioneer/jupiter/ReportEntryExtension.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
# Conflicts: # README.md # docs/report-entries.adoc
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Refer to test method arguments with numbers between curly braces, starting with {0}.
Signed-off-by: Mihaly Verhas misi.verhas@gmail.com
I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.