Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines to non-zero major versions #333

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Sep 8, 2020

Closes #225.

Proposed commit message:

Update contribution guideline to non-zero major versions (#225 / #319)

The contribution guidelines mentioned that the major version "stays
at 0 for now". Change that to account for the looming 1.0 release,
after which new major version increases will be decided by the
maintainer.

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@nipafx nipafx requested a review from Bukama September 8, 2020 19:55
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nipafx nipafx merged commit 2764bc7 into master Oct 6, 2020
@nipafx nipafx deleted the issue/225-contributing-versions branch April 28, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs before releasing version 1.0.0
3 participants