-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new Shipkit plugins #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🥳 Just did a quick scan before one of the maintainers finds time.
Afterwards, we shouldn't forget to remove the obsolete secrets (TRAVIS_BRANCH
etc.).
@slawekjaranowski, thank you! How did you test this change? (please update the PR description) |
As I wrote I tested by command:
and examine output log and build directory |
so we have to rethink this approach anyways, as bintray/jcenter is EOL in may 2021 https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ for now this is fine, but we might have to adapt the process of uploading etc, so we directly push to maven central and sign within gradle |
16908f3
to
4d694ce
Compare
please re-run GitHub Action for PR |
Well that won't restart timeout jobs. Those are only restarted after a new commit. |
4d694ce
to
320052d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for approval. |
Thank you so much for the PR, @slawekjaranowski! I'm sorry that I still didn't take a look at it. It's not for a lack or appreciation, I assure you. I hope to get around to it in the coming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (aside from the merge conflicts)
Kudos, SonarCloud Quality Gate passed! |
Thanks again @slawekjaranowski, merged. :) |
@slawekjaranowski We just released 1.3.8, but expected 1.3.1 - any idea what happened? |
@nipafx Please look at https://github.com/shipkit/shipkit-auto-version#implementation-details |
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Checks
Contributing
README.md
mentions the new contribution (real name optional)I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.