Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new Shipkit plugins #419

Merged
merged 3 commits into from
Feb 28, 2021
Merged

Conversation

slawekjaranowski
Copy link
Contributor

@slawekjaranowski slawekjaranowski commented Jan 30, 2021

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those

Checks

  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)
  • tested localy by commands:
./gradlew  bintrayUpload -PbintrayDryRun
./gradlew generateChangelog

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Copy link
Member

@beatngu13 beatngu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🥳 Just did a quick scan before one of the maintainers finds time.

Afterwards, we shouldn't forget to remove the obsolete secrets (TRAVIS_BRANCH etc.).

.github/workflows/release-build.yml Outdated Show resolved Hide resolved
.github/workflows/release-build.yml Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
version.properties Show resolved Hide resolved
@mockitoguy
Copy link

mockitoguy commented Jan 31, 2021

@slawekjaranowski, thank you! How did you test this change? (please update the PR description)

@slawekjaranowski
Copy link
Contributor Author

slawekjaranowski commented Jan 31, 2021

As I wrote I tested by command:

./gradlew  bintrayUpload -PbintrayDryRun
./gradlew generateChangelog

and examine output log and build directory

build.gradle.kts Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
@aepfli
Copy link
Member

aepfli commented Feb 3, 2021

so we have to rethink this approach anyways, as bintray/jcenter is EOL in may 2021 https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

for now this is fine, but we might have to adapt the process of uploading etc, so we directly push to maven central and sign within gradle

@slawekjaranowski
Copy link
Contributor Author

please re-run GitHub Action for PR

@Bukama
Copy link
Member

Bukama commented Feb 9, 2021

please re-run GitHub Action for PR

Well that won't restart timeout jobs. Those are only restarted after a new commit.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawekjaranowski
Copy link
Contributor Author

Thank you for approval.
Are there something what I should do before merge?

@nipafx
Copy link
Member

nipafx commented Feb 23, 2021

Thank you so much for the PR, @slawekjaranowski! I'm sorry that I still didn't take a look at it. It's not for a lack or appreciation, I assure you. I hope to get around to it in the coming days.

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from the merge conflicts)

@nipafx nipafx linked an issue Feb 28, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nipafx nipafx merged commit 2986c20 into junit-pioneer:master Feb 28, 2021
@nipafx
Copy link
Member

nipafx commented Feb 28, 2021

Thanks again @slawekjaranowski, merged. :)

@nipafx
Copy link
Member

nipafx commented Feb 28, 2021

@slawekjaranowski We just released 1.3.8, but expected 1.3.1 - any idea what happened?

@slawekjaranowski slawekjaranowski deleted the fix-410 branch February 28, 2021 17:37
@slawekjaranowski
Copy link
Contributor Author

@nipafx shipkit-auto-version plugin is responsible for calculating next version during release. In this case we have new 8 commits from last release so version was incremented by 8.

Please look at https://github.com/shipkit/shipkit-auto-version#implementation-details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/replace Shipkit
6 participants