Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to Java 11 #707

Merged
merged 13 commits into from May 2, 2023
Merged

Update code to Java 11 #707

merged 13 commits into from May 2, 2023

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Jan 12, 2023

A first stab ab #706.


PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

build.gradle.kts Show resolved Hide resolved
@beatngu13 beatngu13 marked this pull request as ready for review March 11, 2023 10:19
@beatngu13 beatngu13 added the full-build Triggers full build suite on PR label Mar 11, 2023
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see that we write valid HTML (see comment on "p"-Tag, applies on many changes in the PR)

@beatngu13 beatngu13 requested a review from Bukama April 24, 2023 19:32
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more closing paragraph tag and I'm fine with it (if you added it, see this an approval and feel free to merge, as @beatngu13 already accepted)

@Michael1993 Michael1993 requested a review from Bukama May 2, 2023 12:07
@Michael1993
Copy link
Member

Proposed commit message:

Update code to Java 11 (#706 / #707)

This commit updates the code base to use the language features now
available to us (as we baseline against Java 11).

PR: #707

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience :)

@Bukama Bukama merged commit 5c255d9 into main May 2, 2023
21 checks passed
@Bukama Bukama deleted the lab/java-11 branch May 2, 2023 15:06
@beatngu13 beatngu13 mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants