New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to Java 11 #707
Conversation
src/main/java/org/junitpioneer/internal/PioneerAnnotationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/internal/PioneerAnnotationUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see that we write valid HTML (see comment on "p"-Tag, applies on many changes in the PR)
src/main/java/org/junitpioneer/jupiter/cartesian/CartesianArgumentsSource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/cartesian/CartesianMethodArgumentsProvider.java
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/cartesian/CartesianParameterArgumentsProvider.java
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/issue/IssueExtensionExecutionListener.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more closing paragraph tag and I'm fine with it (if you added it, see this an approval and feel free to merge, as @beatngu13 already accepted)
Proposed commit message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience :)
A first stab ab #706.
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Contributing
README.md
mentions the new contribution (real name optional)