Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo to let the warning render correctly on environment variables docs #710

Merged
merged 1 commit into from Feb 2, 2023

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Jan 26, 2023

Before:

image

After (similar to):

image

Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TWiStErRob ! 👋

Thank you for the fix! If you want, you can add yourself to the README as a contributor! 😄

@TWiStErRob
Copy link
Contributor Author

🫣 rather not boast about removing 1 byte.

@Bukama Bukama added the full-build Triggers full build suite on PR label Jan 26, 2023
@Bukama
Copy link
Member

Bukama commented Jan 26, 2023

Thank you. I'm curios if the other problem you mentioned (see junit-pioneer/junit-pioneer.github.io#35) are also caused by such

@beatngu13 beatngu13 self-requested a review February 2, 2023 17:27
@beatngu13 beatngu13 merged commit 10b91cb into junit-pioneer:main Feb 2, 2023
30 checks passed
@TWiStErRob TWiStErRob deleted the patch-1 branch February 2, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants