New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to load custom ObjectMapper from service #741
Conversation
src/main/java/org/junitpioneer/jupiter/json/DefaultObjectMapperProvider.java
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/json/AbstractJsonArgumentsProvider.java
Outdated
Show resolved
Hide resolved
…into lab/object-mapper-service-loader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general approve, but I suggest to also add tests for the JsonReadFeature.ALLOW_TRAILING_COMMA feature request of #740 which you also added here.
Good catch. Added. |
As I approved, you can merge if you don't have anything else you want to change. I'll be online back tomorrow so feel free to do today. |
Would love some feedback.
Proposed commit message:
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Contributing
README.md
mentions the new contribution (real name optional)