Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load custom ObjectMapper from service #741

Merged
merged 9 commits into from Sep 7, 2023

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Jul 5, 2023

Would love some feedback.

Proposed commit message:

Add option to customise ObjectMapper (#704, #740 / #741)

This PR solves the need to be able to customise the ObjectMapper
in JSON based tests, e.g.: load in services. It also adds the option
ALLOW_TRAILING_COMMA.

Closes: #704, #740
PR: #741

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

@Michael1993 Michael1993 marked this pull request as ready for review August 10, 2023 12:28
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general approve, but I suggest to also add tests for the JsonReadFeature.ALLOW_TRAILING_COMMA feature request of #740 which you also added here.

@Michael1993
Copy link
Member Author

A general approve, but I suggest to also add tests for the JsonReadFeature.ALLOW_TRAILING_COMMA feature request of #740 which you also added here.

Good catch. Added.

@Bukama
Copy link
Member

Bukama commented Sep 6, 2023

A general approve, but I suggest to also add tests for the JsonReadFeature.ALLOW_TRAILING_COMMA feature request of #740 which you also added here.

Good catch. Added.

As I approved, you can merge if you don't have anything else you want to change. I'll be online back tomorrow so feel free to do today.

@Michael1993 Michael1993 merged commit c7bb969 into main Sep 7, 2023
11 checks passed
@Michael1993 Michael1993 deleted the lab/object-mapper-service-loader branch September 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants