Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw MultipleFailuresError when last retry failed #789

Merged
merged 3 commits into from Nov 9, 2023

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Nov 9, 2023

Proposed commit message:

Better report assertion failures in retrying tests (#735 / #789)

IntelliJ (and maybe other tools as well) format test exception
messages in a way that highlights "expected" and "actual" values.
The way @RetryingTest repackages and such exceptions undermines that
special-casing and leads to less readable exception messages.

Change this by formatting the messages of `TestAbortedException`s, so
that the original exception's message shows up first (so it gets
presented well) and use `MultipleFailuresError` on the last failed
test to correctly report all previous errors.

Closes: #735
PR: #789

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code (general)

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Code (new package)

  • The new package is exported in module-info.java
  • The new package is also present in the tests
  • The new package is opened for reflection to JUnit 5 in module-info.java
  • The new package is listed in the contribution guide

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.adoc mentions the new contribution (real name optional)

@nipafx nipafx added the full-build Triggers full build suite on PR label Nov 9, 2023
Co-authored-by: Mihály Verhás <misi.verhas@gmail.com>
@Michael1993 Michael1993 merged commit 4029e59 into main Nov 9, 2023
34 checks passed
@Michael1993 Michael1993 deleted the issue/735-retrying-multiple-errors branch November 9, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants