Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added naming feature to Parameterized (Issue #24). #358

Closed
wants to merge 1 commit into from

Conversation

ffray
Copy link

@ffray ffray commented Nov 5, 2011

This tiny patch implements the feature request #24 "Flexible naming of parameterized tests".
It adds a Name class which can be used as one of the parameters returned by the @parameter method.
The first Name found will be used, if none is found the old parameter index will be used.
In both cases, the old name format will be used, so either "NAME" for a test-class, or "method [NAME]" for each test-method.

Hope you'll find it as useful as I do, so please have a look.
Kindly asking to pull this feature.

Best regards,

Florian

@ddimtirov
Copy link

Hi Florian, seems we've been having the same issue, but we've taken different approaches.
Feel free to check out my patch - https://github.com/KentBeck/junit/pull/145

@dsaff
Copy link
Member

dsaff commented Feb 24, 2012

@ffray, any opinions on @ddimtirov's approach? I'd love to get community consensus behind one of the proposals.

@ffray
Copy link
Author

ffray commented Feb 25, 2012

Hi David,

I'm absolutely fine with Dimitars' approach.

Best regards,

Florian

@dsaff
Copy link
Member

dsaff commented Mar 27, 2012

Closing in favor of #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants