Fix for #359 #362
Merged
Fix for #359 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, It would be great if it this fix could be included in the next JUnit release. We built a private version of JUnit because of this, but of course it would be much cleaner to use official release. Thanks in advance; N. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests ok, both on 4.11 trunk & on 4.10 final
Implementation uses getClass().getClassLoader() vs. Thread.currentThread().getContextClassLoader() because some third parties (in my case: maven/surefire in JUnit47 provider) rely on it.
With this fix you keep exactly the same behavior as before so there should be no impact for anyone.