Remove @Deprecated from MethodRule and related methods. #519
Conversation
|
I'm good with this change, but I fell behind in reviews, and now it's not automatically mergeable. Can you merge and push again? Sorry, and thanks. |
|
@kcooney, this should be safe to merge in before 4.11. Do you have time to fix the merge? (FYI, @marcphilipp) |
Conflicts: src/main/java/org/junit/ClassRule.java src/main/java/org/junit/Rule.java src/main/java/org/junit/rules/MethodRule.java src/main/java/org/junit/rules/TestWatchman.java src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java
|
Sorry for the delay; my day job has been busy. PTAL |
|
@dsaff +1 Makes sense to be merged before 4.11 is released. |
|
There's a lot of formatting churn still in this pull. I'm hoping, on another thread, to get @awulder to check in the Eclipse formatting file he used, so that we can automatically remove the churn. |
|
@dsaff Actually the formatting is only in Javadoc comments and looks like it is in accordance with the style guide (4 character indentation). IMHO this can be merged. |
Remove @deprecated from MethodRule and related methods.
|
Thanks! |
Many developers are legitimate reasons to stick with MethodRule and the JUnit team has
no plans to remove support for MethodRule, so removing the @deprecated annotations
from MethodRule and methods that use MethodRule.