Rename dynamicTestFound to dynamicTestRegistered

Issue: #34 ------------------------------------------------------------------------ On behalf of the community, the JUnit Lambda Team thanks Netcetera AG (http://netcetera.com) for supporting the JUnit crowdfunding campaign! ------------------------------------------------------------------------
junit-team · Dec 11, 2015 · 16d43f8 · 16d43f8
1 parent 99aaaf5
commit 16d43f8
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 10 deletions.
diff --git a/junit-console/src/main/java/org/junit/gen5/console/tasks/ColoredPrintingTestListener.java b/junit-console/src/main/java/org/junit/gen5/console/tasks/ColoredPrintingTestListener.java
@@ -43,7 +43,7 @@ public void testPlanExecutionFinished(TestPlan testPlan) {
 	}
 
 	@Override
-	public void dynamicTestFound(TestIdentifier testIdentifier) {
+	public void dynamicTestRegistered(TestIdentifier testIdentifier) {
 		printlnTestDescriptor(BLUE, "Test found:", testIdentifier);
 	}
 

diff --git a/junit-engine-api/src/main/java/org/junit/gen5/engine/EngineExecutionListener.java b/junit-engine-api/src/main/java/org/junit/gen5/engine/EngineExecutionListener.java
@@ -15,7 +15,7 @@
  */
 public interface EngineExecutionListener {
 
-	default void dynamicTestFound(TestDescriptor testDescriptor) {
+	default void dynamicTestRegistered(TestDescriptor testDescriptor) {
 	}
 
 	default void testStarted(TestDescriptor testDescriptor) {

diff --git a/junit-launcher/src/main/java/org/junit/gen5/launcher/Launcher.java b/junit-launcher/src/main/java/org/junit/gen5/launcher/Launcher.java
@@ -96,8 +96,10 @@ public ExecutionListenerAdapter(TestPlan testPlan, TestExecutionListener testExe
 		}
 
 		@Override
-		public void dynamicTestFound(TestDescriptor testDescriptor) {
-			testExecutionListener.dynamicTestFound(getTestIdentifier(testDescriptor));
+		public void dynamicTestRegistered(TestDescriptor testDescriptor) {
+			TestIdentifier testIdentifier = TestIdentifier.from(testDescriptor);
+			testPlan.add(testIdentifier);
+			testExecutionListener.dynamicTestRegistered(getTestIdentifier(testDescriptor));
 		}
 
 		@Override

diff --git a/junit-launcher/src/main/java/org/junit/gen5/launcher/TestExecutionListener.java b/junit-launcher/src/main/java/org/junit/gen5/launcher/TestExecutionListener.java
@@ -21,7 +21,7 @@ default void testPlanExecutionStarted(TestPlan testPlan) {
 	default void testPlanExecutionFinished(TestPlan testPlan) {
 	}
 
-	default void dynamicTestFound(TestIdentifier testIdentifier) {
+	default void dynamicTestRegistered(TestIdentifier testIdentifier) {
 	}
 
 	default void testStarted(TestIdentifier testIdentifier) {

diff --git a/junit-launcher/src/main/java/org/junit/gen5/launcher/TestExecutionListenerRegistry.java b/junit-launcher/src/main/java/org/junit/gen5/launcher/TestExecutionListenerRegistry.java
@@ -38,8 +38,8 @@ TestExecutionListener getCompositeTestExecutionListener() {
 	private class CompositeTestExecutionListener implements TestExecutionListener {
 
 		@Override
-		public void dynamicTestFound(TestIdentifier testIdentifier) {
-			notifyTestExecutionListeners(listener -> listener.dynamicTestFound(testIdentifier));
+		public void dynamicTestRegistered(TestIdentifier testIdentifier) {
+			notifyTestExecutionListeners(listener -> listener.dynamicTestRegistered(testIdentifier));
 		}
 
 		@Override

diff --git a/junit-launcher/src/main/java/org/junit/gen5/launcher/listeners/LoggingListener.java b/junit-launcher/src/main/java/org/junit/gen5/launcher/listeners/LoggingListener.java
@@ -38,7 +38,7 @@ public void testPlanExecutionFinished(TestPlan testPlan) {
 	}
 
 	@Override
-	public void dynamicTestFound(TestIdentifier testIdentifier) {
+	public void dynamicTestRegistered(TestIdentifier testIdentifier) {
 		log("dynamicTestFound: %s - %s", testIdentifier.getDisplayName(), testIdentifier.getUniqueId());
 	}
 

diff --git a/...launcher/src/main/java/org/junit/gen5/launcher/listeners/SummaryCreatingTestListener.java b/...launcher/src/main/java/org/junit/gen5/launcher/listeners/SummaryCreatingTestListener.java
@@ -44,7 +44,7 @@ public void testPlanExecutionFinished(TestPlan testPlan) {
 	}
 
 	@Override
-	public void dynamicTestFound(TestIdentifier testIdentifier) {
+	public void dynamicTestRegistered(TestIdentifier testIdentifier) {
 		summary.testsFound.incrementAndGet();
 	}
 

diff --git a/junit4-launcher-runner/src/main/java/org/junit/gen5/junit4runner/JUnit5RunnerListener.java b/junit4-launcher-runner/src/main/java/org/junit/gen5/junit4runner/JUnit5RunnerListener.java
@@ -41,7 +41,7 @@ public void testPlanExecutionFinished(TestPlan testPlan) {
 	}
 
 	@Override
-	public void dynamicTestFound(TestIdentifier testIdentifier) {
+	public void dynamicTestRegistered(TestIdentifier testIdentifier) {
 		System.out.println("JUnit5 test runner cannot handle dynamic tests");
 	}