Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#40: Introduce TestClassRequestResolver
Extract creating TestDescriptor from class requests out of JUnit4DiscoveryRequestResolver into separate class.
- Loading branch information
1 parent
960fee7
commit 1e4707b
Showing
3 changed files
with
126 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...engine/src/main/java/org/junit/gen5/engine/junit4/discovery/TestClassRequestResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Copyright 2015-2016 the original author or authors. | ||
| * | ||
| * All rights reserved. This program and the accompanying materials are | ||
| * made available under the terms of the Eclipse Public License v1.0 which | ||
| * accompanies this distribution and is available at | ||
| * | ||
| * http://www.eclipse.org/legal/epl-v10.html | ||
| */ | ||
|
|
||
| package org.junit.gen5.engine.junit4.discovery; | ||
|
|
||
| import static java.util.stream.Collectors.groupingBy; | ||
| import static java.util.stream.Collectors.toCollection; | ||
| import static org.junit.gen5.engine.junit4.descriptor.JUnit4TestDescriptor.DEFAULT_SEPARATOR; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Map.Entry; | ||
| import java.util.Set; | ||
| import java.util.function.IntFunction; | ||
|
|
||
| import org.junit.gen5.engine.EngineDescriptor; | ||
| import org.junit.gen5.engine.junit4.descriptor.JUnit4TestDescriptor; | ||
| import org.junit.gen5.engine.junit4.descriptor.RunnerTestDescriptor; | ||
| import org.junit.runner.Description; | ||
| import org.junit.runner.Runner; | ||
| import org.junit.runner.manipulation.Filter; | ||
| import org.junit.runners.model.RunnerBuilder; | ||
|
|
||
| class TestClassRequestResolver { | ||
|
|
||
| private final EngineDescriptor engineDescriptor; | ||
|
|
||
| TestClassRequestResolver(EngineDescriptor engineDescriptor) { | ||
| this.engineDescriptor = engineDescriptor; | ||
| } | ||
|
|
||
| void populateEngineDescriptorFrom(Set<TestClassRequest> requests) { | ||
| RunnerBuilder runnerBuilder = new DefensiveAllDefaultPossibilitiesBuilder(); | ||
| for (TestClassRequest request : requests) { | ||
| Class<?> testClass = request.getTestClass(); | ||
| Runner runner = runnerBuilder.safeRunnerForClass(testClass); | ||
| if (runner != null) { | ||
| addRunnerTestDescriptor(request, testClass, runner); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void addRunnerTestDescriptor(TestClassRequest request, Class<?> testClass, Runner runner) { | ||
| RunnerTestDescriptor runnerTestDescriptor = determineRunnerTestDescriptor(testClass, runner, | ||
| request.getFilters()); | ||
| engineDescriptor.addChild(runnerTestDescriptor); | ||
| } | ||
|
|
||
| private RunnerTestDescriptor determineRunnerTestDescriptor(Class<?> testClass, Runner runner, | ||
| List<RunnerTestDescriptorAwareFilter> filters) { | ||
| RunnerTestDescriptor runnerTestDescriptor = createCompleteRunnerTestDescriptor(testClass, runner); | ||
| if (!filters.isEmpty()) { | ||
| Filter filter = createOrFilter(filters, runnerTestDescriptor); | ||
| Runner filteredRunner = runnerTestDescriptor.toRequest().filterWith(filter).getRunner(); | ||
| // TODO #40 Log warning if runner does not implement Filterable | ||
| runnerTestDescriptor = createCompleteRunnerTestDescriptor(testClass, filteredRunner); | ||
| } | ||
| return runnerTestDescriptor; | ||
| } | ||
|
|
||
| private Filter createOrFilter(List<RunnerTestDescriptorAwareFilter> filters, | ||
| RunnerTestDescriptor runnerTestDescriptor) { | ||
| filters.stream().forEach(filter -> filter.initialize(runnerTestDescriptor)); | ||
| return new OrFilter(filters); | ||
| } | ||
|
|
||
| private RunnerTestDescriptor createCompleteRunnerTestDescriptor(Class<?> testClass, Runner runner) { | ||
| RunnerTestDescriptor runnerTestDescriptor = new RunnerTestDescriptor(engineDescriptor, testClass, runner); | ||
| addChildrenRecursively(runnerTestDescriptor); | ||
| return runnerTestDescriptor; | ||
| } | ||
|
|
||
| private void addChildrenRecursively(JUnit4TestDescriptor parent) { | ||
| List<Description> children = parent.getDescription().getChildren(); | ||
| // Use LinkedHashMap to preserve order, ArrayList for fast access by index | ||
| Map<String, List<Description>> childrenByUniqueId = children.stream().collect( | ||
| groupingBy(UniqueIdExtractor::toUniqueId, LinkedHashMap::new, toCollection(ArrayList::new))); | ||
| for (Entry<String, List<Description>> entry : childrenByUniqueId.entrySet()) { | ||
| String uniqueId = entry.getKey(); | ||
| List<Description> childrenWithSameUniqueId = entry.getValue(); | ||
| IntFunction<String> uniqueIdGenerator = determineUniqueIdGenerator(uniqueId, childrenWithSameUniqueId); | ||
| for (int index = 0; index < childrenWithSameUniqueId.size(); index++) { | ||
| String reallyUniqueId = uniqueIdGenerator.apply(index); | ||
| Description description = childrenWithSameUniqueId.get(index); | ||
| JUnit4TestDescriptor child = new JUnit4TestDescriptor(parent, DEFAULT_SEPARATOR, reallyUniqueId, | ||
| description); | ||
| parent.addChild(child); | ||
| addChildrenRecursively(child); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private IntFunction<String> determineUniqueIdGenerator(String uniqueId, | ||
| List<Description> childrenWithSameUniqueId) { | ||
| if (childrenWithSameUniqueId.size() == 1) { | ||
| return index -> uniqueId; | ||
| } | ||
| return index -> uniqueId + "[" + index + "]"; | ||
| } | ||
| } |