#58 Unique id for dynamic test created with index

junit-team · Mar 4, 2016 · 390a238 · 390a238
1 parent 340fdc6
commit 390a238
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...ne/src/main/java/org/junit/gen5/engine/junit5/descriptor/DynamicMethodTestDescriptor.java b/...ne/src/main/java/org/junit/gen5/engine/junit5/descriptor/DynamicMethodTestDescriptor.java
@@ -14,6 +14,7 @@
 import static org.junit.gen5.engine.junit5.execution.MethodInvocationContextFactory.methodInvocationContext;
 
 import java.lang.reflect.Method;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Stream;
 
 import org.junit.gen5.api.DynamicTest;
@@ -61,12 +62,14 @@ protected void invokeTestMethod(JUnit5EngineExecutionContext context, TestExtens
 			//Todo: Handle cast exceptions
 			Stream<DynamicTest> dynamicTestStream = (Stream<DynamicTest>) methodInvoker.invoke(methodInvocationContext);
 
-			dynamicTestStream.forEach(dynamicTest -> registerAndExecute(dynamicTest, listener));
+			AtomicInteger index = new AtomicInteger();
+			dynamicTestStream.forEach(
+				dynamicTest -> registerAndExecute(dynamicTest, index.incrementAndGet(), listener));
 		});
 	}
 
-	private void registerAndExecute(DynamicTest dynamicTest, EngineExecutionListener listener) {
-		String uniqueId = getUniqueId() + ":" + dynamicTest.getName();
+	private void registerAndExecute(DynamicTest dynamicTest, int index, EngineExecutionListener listener) {
+		String uniqueId = getUniqueId() + "%" + index;
 		DynamicTestTestDescriptor dynamicTestTestDescriptor = new DynamicTestTestDescriptor(uniqueId, dynamicTest,
 			getSource().get());
 		addChild(dynamicTestTestDescriptor);