Trying to resolve methods that are not test methods is logged as info

junit-team · Apr 29, 2016 · 6bf76b6 · 6bf76b6
1 parent 24e0a90
commit 6bf76b6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/...c/test/java/org/junit/gen5/engine/junit5/discoveryNEW/DiscoverySelectorResolverTests.java b/...c/test/java/org/junit/gen5/engine/junit5/discoveryNEW/DiscoverySelectorResolverTests.java
@@ -186,7 +186,7 @@ public void testNonResolvableUniqueId() {
 			"Exception message wrong: " + exception.getMessage());
 	}
 
-	// @Test
+	@Test
 	public void resolvingUniqueIdOfNonTestMethodResolvesNothing() {
 		UniqueIdSelector selector = UniqueIdSelector.forUniqueId(uniqueIdForMethod(MyTestClass.class, "notATest()"));
 		EngineDiscoveryRequest request = request().select(selector).build();

diff --git a/...engine/src/main/java/org/junit/gen5/engine/junit5/discoveryNEW/TestContainerResolver.java b/...engine/src/main/java/org/junit/gen5/engine/junit5/discoveryNEW/TestContainerResolver.java
@@ -26,9 +26,9 @@
 
 public class TestContainerResolver implements ElementResolver {
 
-	private static final Logger LOG = Logger.getLogger(TestContainerResolver.class.getName());
+	public static final String SEGMENT_TYPE = "class";
 
-	private static final String SEGMENT_TYPE = "class";
+	private static final Logger LOG = Logger.getLogger(TestContainerResolver.class.getName());
 
 	@Override
 	public Set<TestDescriptor> resolve(AnnotatedElement element, TestDescriptor parent) {
@@ -37,7 +37,7 @@ public Set<TestDescriptor> resolve(AnnotatedElement element, TestDescriptor pare
 
 		Class<?> clazz = (Class<?>) element;
 		if (!isPotentialTestContainer(clazz)) {
-			LOG.warning(() -> {
+			LOG.info(() -> {
 				String classDescription = clazz.getName();
 				return format("Class '%s' is not a test container", classDescription);
 			});

diff --git a/...t5-engine/src/main/java/org/junit/gen5/engine/junit5/discoveryNEW/TestMethodResolver.java b/...t5-engine/src/main/java/org/junit/gen5/engine/junit5/discoveryNEW/TestMethodResolver.java
@@ -10,11 +10,14 @@
 
 package org.junit.gen5.engine.junit5.discoveryNEW;
 
+import static java.lang.String.format;
+
 import java.lang.reflect.AnnotatedElement;
 import java.lang.reflect.Method;
 import java.util.Collections;
 import java.util.Optional;
 import java.util.Set;
+import java.util.logging.Logger;
 
 import org.junit.gen5.engine.TestDescriptor;
 import org.junit.gen5.engine.UniqueId;
@@ -27,6 +30,8 @@ public class TestMethodResolver implements ElementResolver {
 
 	public static final String SEGMENT_TYPE = "method";
 
+	private static final Logger LOG = Logger.getLogger(TestMethodResolver.class.getName());
+
 	private boolean canResolveElement(AnnotatedElement element, TestDescriptor parent) {
 		//Do not collapse
 		if (!(element instanceof Method))
@@ -46,6 +51,11 @@ public Set<TestDescriptor> resolve(AnnotatedElement element, TestDescriptor pare
 
 		Method testMethod = (Method) element;
 		if (!isTestMethod(testMethod)) {
+			LOG.info(() -> {
+				String methodDescription = testMethod.getDeclaringClass().getName() + "#" + testMethod.getName();
+				return format("Method '%s' is not a test method", methodDescription);
+			});
+
 			return Collections.emptySet();
 		}