Skip to content

Commit

Permalink
Suggestion implemented
Browse files Browse the repository at this point in the history
  • Loading branch information
@jlink
jlink committed Jan 19, 2016
1 parent 69d6e1d commit 73347b3
Show file tree
Hide file tree
Showing 8 changed files with 208 additions and 263 deletions.
38 changes: 9 additions & 29 deletions junit-tests/src/test/java/org/junit/gen5/engine/junit5/descriptor/ExtensionContextTests.java
View file
Expand Up @@ -122,45 +122,25 @@ public void reportEntriesArePublishedToExecutionContext() {
}

@Test
public void storingAttributesWithDefaultNamespace() {
public void usingStore() {
MethodTestDescriptor methodTestDescriptor = methodDescriptor();
ClassTestDescriptor classTestDescriptor = outerClassDescriptor(methodTestDescriptor);
ExtensionContext parentContext = new ClassBasedContainerExtensionContext(null, null, classTestDescriptor);
MethodBasedTestExtensionContext childContext = new MethodBasedTestExtensionContext(parentContext, null,
methodTestDescriptor, new OuterClass());

childContext.put("a key", "a value");
assertEquals("a value", childContext.get("a key"));
ExtensionContext.Store store = childContext.getStore();

assertEquals("other value", childContext.getOrComputeIfAbsent("other key", key -> "other value"));
store.put("a key", "a value");
assertEquals("a value", store.get("a key"));

childContext.remove("a key");
assertNull(childContext.get("a key"));
assertEquals("other value", store.getOrComputeIfAbsent("other key", key -> "other value"));

parentContext.put("parent key", "parent value");
assertEquals("parent value", childContext.get("parent key"));
}

@Test
public void storingAttributesWithNamespace() {
MethodTestDescriptor methodTestDescriptor = methodDescriptor();
ClassTestDescriptor classTestDescriptor = outerClassDescriptor(methodTestDescriptor);
ExtensionContext parentContext = new ClassBasedContainerExtensionContext(null, null, classTestDescriptor);
MethodBasedTestExtensionContext childContext = new MethodBasedTestExtensionContext(parentContext, null,
methodTestDescriptor, new OuterClass());

String namespace = "a namespace";

childContext.put("a key", "a value", namespace);
assertEquals("a value", childContext.get("a key", namespace));

assertEquals("other value", childContext.getOrComputeIfAbsent("other key", key -> "other value"), namespace);

childContext.remove("a key", namespace);
assertNull(childContext.get("a key", namespace));
assertEquals("a value", store.remove("a key"));
assertNull(store.get("a key"));

parentContext.put("parent key", "parent value", namespace);
assertEquals("parent value", childContext.get("parent key", namespace));
store.put("parent key", "parent value");
assertEquals("parent value", store.get("parent key"));
}

private ClassTestDescriptor nestedClassDescriptor() {
Expand Down
115 changes: 59 additions & 56 deletions ...tests/src/test/java/org/junit/gen5/engine/junit5/descriptor/ExtensionValuesStoreTest.java
View file
Expand Up @@ -15,7 +15,7 @@
import org.junit.gen5.api.BeforeEach;
import org.junit.gen5.api.Nested;
import org.junit.gen5.api.Test;
import org.junit.gen5.engine.junit5.descriptor.ExtensionValuesStore.Namespace;
import org.junit.gen5.api.extension.ExtensionContext.*;

/**
* Microtests for {@link ExtensionValuesStore}
Expand All @@ -29,131 +29,134 @@ class ExtensionValuesStoreTests {

private Object value = createObject("value");

private Namespace namespace = Namespace.of("ns");

@BeforeEach
void initializeStore() {
parentStore = new ExtensionValuesStore();
store = new ExtensionValuesStore(parentStore);
}

@Nested
class UsingDefaultNamespaceTests {
class StoringValuesTests {

@Test
void getWithUnknownKeyReturnsNull() {
assertNull(store.get("unknown key"));
assertNull(store.get("unknown key", namespace));
}

@Test
void putAndGetWithSameKey() {

store.put(key, value);
assertEquals(value, store.get(key));
store.put(key, value, namespace);
assertEquals(value, store.get(key, namespace));
}

@Test
void valueCanBeReplaced() {
store.put(key, value);
store.put(key, value, namespace);

Object newValue = new Object();
store.put(key, newValue);
store.put(key, newValue, namespace);

assertEquals(newValue, store.get(key));
assertEquals(newValue, store.get(key, namespace));
}

@Test
void valueIsComputedIfAbsent() {
assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> value));
assertEquals(value, store.get(key));
assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> value, namespace));
assertEquals(value, store.get(key, namespace));
}

@Test
void valueIsNotComputedIfPresent() {
store.put(key, value);
store.put(key, value, namespace);

assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> "a different value"));
assertEquals(value, store.get(key));
assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> "a different value", namespace));
assertEquals(value, store.get(key, namespace));
}

@Test
void nullIsAValidValueToPut() {
store.put(key, null);
store.put(key, null, namespace);

assertEquals(null, store.getOrComputeIfAbsent(key, innerKey -> "a different value"));
assertEquals(null, store.get(key));
assertEquals(null, store.getOrComputeIfAbsent(key, innerKey -> "a different value", namespace));
assertEquals(null, store.get(key, namespace));
}

@Test
void keysCanBeRemoved() {
store.put(key, value);
store.remove(key);
store.put(key, value, namespace);
assertEquals(value, store.remove(key, namespace));

assertNull(store.get(key));
assertEquals("a different value", store.getOrComputeIfAbsent(key, innerKey -> "a different value"));
assertNull(store.get(key, namespace));
assertEquals("a different value",
store.getOrComputeIfAbsent(key, innerKey -> "a different value", namespace));
}

}
@Test
void sameKeyWithDifferentNamespaces() {
Object value1 = createObject("value1");
Namespace namespace1 = Namespace.of("ns1");

@Nested
class InheritedValuesTests {
Object value2 = createObject("value2");
Namespace namespace2 = Namespace.of("ns2");

@Test
void valueFromParentIsVisible() {
parentStore.put(key, value);
assertEquals(value, store.get(key));
store.put(key, value1, namespace1);
store.put(key, value2, namespace2);

assertEquals(value1, store.get(key, namespace1));
assertEquals(value2, store.get(key, namespace2));
}

@Test
void valueFromParentCanBeOverriddenInChild() {
parentStore.put(key, value);
void valueIsComputedIfAbsentInDifferentNamespace() {
Namespace namespace1 = Namespace.of("ns1");
Namespace namespace2 = Namespace.of("ns2");

Object otherValue = new Object();
store.put(key, otherValue);
assertEquals(otherValue, store.get(key));
assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> value, namespace1));
assertEquals(value, store.get(key, namespace1));

assertEquals(value, parentStore.get(key));
assertNull(store.get(key, namespace2));
}
}

@Nested
class UsingExplicitNamespaceTests {

@Test
void sameKeyWithDifferentNamespaces() {
Object value1 = createObject("value1");
Namespace namespace1 = Namespace.sharedWith("ns1");
void keyIsOnlyRemovedInGivenNamespace() {
Namespace namespace1 = Namespace.of("ns1");
Namespace namespace2 = Namespace.of("ns2");

Object value1 = createObject("value1");
Object value2 = createObject("value2");
Namespace namespace2 = Namespace.sharedWith("ns2");

store.put(key, value1, namespace1);
store.put(key, value2, namespace2);
store.remove(key, namespace1);

assertEquals(value1, store.get(key, namespace1));
assertNull(store.get(key, namespace1));
assertEquals(value2, store.get(key, namespace2));
}

}

@Nested
class InheritedValuesTests {

@Test
void valueIsComputedIfAbsentInDifferentNamespace() {
Namespace namespace = Namespace.sharedWith("ns");
assertEquals(value, store.getOrComputeIfAbsent(key, innerKey -> value, namespace));
void valueFromParentIsVisible() {
parentStore.put(key, value, namespace);
assertEquals(value, store.get(key, namespace));

assertNull(store.get(key));
}

@Test
void keyIsOnlyRemovedInGivenNamespace() {
Namespace namespace = Namespace.sharedWith("ns");
Object valueInNamespace = createObject("valueInNamespace");
void valueFromParentCanBeOverriddenInChild() {
parentStore.put(key, value, namespace);

store.put(key, value);
store.put(key, valueInNamespace, namespace);
store.remove(key, namespace);
Object otherValue = new Object();
store.put(key, otherValue, namespace);
assertEquals(otherValue, store.get(key, namespace));

assertNull(store.get(key, namespace));
assertEquals(value, store.get(key));
assertEquals(value, parentStore.get(key, namespace));
}

}

private Object createObject(final String display) {
Expand Down

0 comments on commit 73347b3

Please sign in to comment.