Add tests for CollectionUtils#getFirstElement

junit-team · May 1, 2024 · 9aeec78 · 9aeec78
1 parent bc80531
commit 9aeec78
Show file tree

Hide file tree

Showing 2 changed files with 252 additions and 200 deletions.
diff --git a/junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java b/junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
@@ -83,7 +83,7 @@ public static <T> Optional<T> getFirstElement(Collection<T> collection) {
 		Preconditions.notNull(collection, "collection must not be null");
 		return collection.isEmpty() //
 				? Optional.empty() //
-				: Optional.of(firstElement(collection));
+				: Optional.ofNullable(firstElement(collection));
 	}
 
 	private static <T> T firstElement(Collection<T> collection) {