Add jdk package in default pruning pattern

junit-team · May 5, 2023 · e0d5fc0 · e0d5fc0
1 parent 45d16de
commit e0d5fc0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java b/junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java
@@ -215,7 +215,7 @@ public class LauncherConstants {
 	 * @see #STACKTRACE_PRUNING_PATTERN_PROPERTY_NAME
 	 */
 	@API(status = EXPERIMENTAL, since = "1.10")
-	public static final String STACKTRACE_PRUNING_DEFAULT_PATTERN = "org.junit.*,java.*";
+	public static final String STACKTRACE_PRUNING_DEFAULT_PATTERN = "org.junit.*,java.*,jdk.*";
 
 	private LauncherConstants() {
 		/* no-op */

diff --git a/platform-tests/src/test/java/org/junit/platform/StackTracePruningTests.java b/platform-tests/src/test/java/org/junit/platform/StackTracePruningTests.java
@@ -46,10 +46,11 @@ void shouldPruneStackTraceByDefault() {
 
 		assertStackTraceMatch(stackTrace, """
 				\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
-				>>>>
 				""");
 
 		assertStackTraceDoesNotContain(stackTrace, "java.util.ArrayList.forEach(ArrayList.java:");
+		assertStackTraceDoesNotContain(stackTrace,
+			"jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:");
 	}
 
 	@Test
@@ -63,10 +64,11 @@ void shouldPruneStackTraceWhenEnabled() {
 
 		assertStackTraceMatch(stackTrace, """
 				\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
-				>>>>
 				""");
 
 		assertStackTraceDoesNotContain(stackTrace, "java.util.ArrayList.forEach(ArrayList.java:");
+		assertStackTraceDoesNotContain(stackTrace,
+			"jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:");
 	}
 
 	@Test
@@ -97,6 +99,14 @@ void shouldPruneStackTraceAccordingToPattern() {
 
 		List<StackTraceElement> stackTrace = extractStackTrace(results);
 
+		assertStackTraceMatch(stackTrace, """
+				\\Qorg.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:\\E.+
+				\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
+				>>>>
+				\\Qjava.base/java.util.ArrayList.forEach(ArrayList.java:\\E.+
+				>>>>
+				""");
+
 		assertStackTraceDoesNotContain(stackTrace, "jdk.");
 	}