Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run jdeps --check on all modules #1939

Closed
2 tasks
sormuras opened this issue Jun 27, 2019 · 7 comments
Closed
2 tasks

Run jdeps --check on all modules #1939

sormuras opened this issue Jun 27, 2019 · 7 comments

Comments

@sormuras
Copy link
Member

sormuras commented Jun 27, 2019

Description

Running jdeps [...] --check org.junit.platform.commons yields:

org.junit.platform.commons (file:///Z:/junit10570588147507757156/lib/junit-platform-commons-1.5.0-SNAPSHOT.jar)
  [Module descriptor]
    requires mandated java.base;
    requires java.compiler;
    requires java.logging;
    requires transitive org.apiguardian.api (@1.1.0);
  [Suggested module descriptor for org.junit.platform.commons]
    requires mandated java.base;
    requires java.compiler;
    requires java.logging;
    requires transitive org.apiguardian.api;
  [Transitive reduced graph for org.junit.platform.commons]
    requires mandated java.base;
    requires java.compiler;
    requires java.logging;
    requires transitive org.apiguardian.api;
  [Unused qualified exports in org.junit.platform.commons]
    exports org.junit.platform.commons.logging to org.junit.jupiter.migrationsupport,org.junit.jupiter.params,org.junit.platform.console,org.junit.platform.reporting,org.junit.platform.runner,org.junit.platform.suite.api
    exports org.junit.platform.commons.util to org.junit.platform.suite.api

Analysis

  • Directives actually compiled into the the module descriptor ([Module descriptor]) do match those listed below [Suggested module descriptor for <module>].
  • Directives listed below [Transitive reduced graph for <module>] ignored here, as we should favor the explicite declaration of all required modules.
  • Directives listed below [Unused qualified exports in <module>] may be pruned from the module descriptor. Or they may stay for potential future-use.

Deliverables

  • Add integration test checking all modules
  • Consult output and apply suggested directives when applicable
@djchapm
Copy link

djchapm commented Nov 27, 2019

+1, maven enforcer build plugin errors multiple versions of apiguardian-api are referenced - 1.1.0 and 1.0.0.
Dependency convergence error for org.apiguardian:apiguardian-api:1.1.0 paths to dependency are:
+-org.junit.jupiter:junit-jupiter-engine:5.5.2
+-org.apiguardian:apiguardian-api:1.1.0
and
+-org.junit.jupiter:junit-jupiter-engine:5.5.2
+-org.junit.platform:junit-platform-engine:1.3.2
+-org.apiguardian:apiguardian-api:1.0.0
and
+-org.junit.jupiter:junit-jupiter-engine:5.5.2
+-org.junit.platform:junit-platform-engine:1.3.2
+-org.junit.platform:junit-platform-commons:1.3.2
+-org.apiguardian:apiguardian-api:1.0.0
and
+-org.junit.jupiter:junit-jupiter-engine:5.5.2
+-org.junit.jupiter:junit-jupiter-api:5.3.2
+-org.apiguardian:apiguardian-api:1.0.0

@marcphilipp
Copy link
Member

@djchapm Where's the 1.0.0 dependency coming from? Our artifacts all reference 1.1.0.

@djchapm
Copy link

djchapm commented Nov 27, 2019

That print out above was mvn enforcer... telling me that junit-jupiter-qpi 5.3.2 had a dependency on apiguardian 1.0.0... however now - I'm not able to reproduce! I've been changing a lot, but this was part of an upgrade stumble I ran into and I think it resolved on changing surefire plugin maybe?

@sormuras
Copy link
Member Author

[...] I think it resolved on changing surefire plugin maybe?

99% sure. ;-)

@sormuras
Copy link
Member Author

Further investigation and automation of this is blocked by https://bugs.openjdk.java.net/browse/JDK-8225773 -- here's a MVE project: https://github.com/sormuras/JDK-8225773

@stale
Copy link

stale bot commented May 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label May 13, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically closed due to inactivity. If you have a good use case for this feature, please feel free to reopen the issue.

@stale stale bot closed this as completed Jun 3, 2021
@marcphilipp marcphilipp removed this from the 5.8 Backlog milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants