Revise module declarations #2063

sormuras · 2019-10-14T19:37:53Z

Revise module declarations for wrong, unnecessary and superfluous directives and modifiers.

Related issue: #1939

Deliverables

Check if transitive is really needed for each requires directive that declares it
All internal packages are hidden, i.e. not exported
All modules are required explicitly when an exported package is used directly

The text was updated successfully, but these errors were encountered:

sormuras · 2019-12-03T17:46:16Z

Module org.junit.platform.engine does not export package org.junit.platform.engine.support.filter - although it contains the published ClasspathScanningSupport class. That class, deprecated, is used by 3rd-party engines. Like: https://github.com/testng-team/testng-junit5/blob/master/src/main/java/org/testng/junit5/TestNGine.java#L3

Error message reads:

Caused by: java.lang.IllegalAccessError: class org.testng.junit5.TestNGine (in module testng.junit5) cannot access class org.junit.platform.engine.support.filter.ClasspathScanningSupport (in module org.junit.platform.engine) because module org.junit.platform.engine does not export org.junit.platform.engine.support.filter to module testng.junit5
at testng.junit5/org.testng.junit5.TestNGine.discover(TestNGine.java:48)
at org.junit.platform.launcher@1.6.0-M1/org.junit.platform.launcher.core.DefaultLauncher.discoverEngineRoot(DefaultLauncher.java:181)

We should export the package in the upcoming 5.6 release.

Issue #2063

sormuras · 2019-12-05T10:47:29Z

Is `transitive` needed for `requires transitive org.apiguardian.api;`?

Yes. E.g org.apiguardian.api.API is part of "all" JUnit 5 API and it is annotated with @Retention(RUNTIME) -- so it leaks to all downstream modules.

Is `transitive` needed for `requires transitive org.opentest4j;`?

Yes. E.g. Assertions.assertAll(...) throws org.opentest4j.MultipleFailuresError

sormuras · 2019-12-18T12:12:05Z

org.junit.jupiter

org.junit.jupiter (junit-jupiter-5.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.junit.jupiter.api;
    requires transitive org.junit.jupiter.engine;
    requires transitive org.junit.jupiter.params;
  [Suggested module descriptor for org.junit.jupiter]
    requires mandated java.base;
  [Transitive reduced graph for org.junit.jupiter]
    requires mandated java.base;
    requires org.junit.jupiter.engine;
    requires org.junit.jupiter.params;

sormuras · 2019-12-18T12:14:16Z

org.junit.jupiter.api

org.junit.jupiter.api (junit-jupiter-api-5.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.platform.commons;
    requires transitive org.opentest4j (@1.2.0);
  [Suggested module descriptor for org.junit.jupiter.api]
    requires mandated java.base;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.platform.commons;
    requires transitive org.opentest4j;
    requires transitive unnamed;
java.lang.NullPointerException
	at jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)

https://github.com/sormuras/JDK-8225773/runs/354396322#step:4:166

sormuras · 2019-12-18T12:16:17Z

org.junit.jupiter.engine

org.junit.jupiter.engine (junit-jupiter-engine-5.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.jupiter.api;
    requires transitive org.junit.platform.engine;
    requires transitive org.opentest4j (@1.2.0);
  [Suggested module descriptor for org.junit.jupiter.engine]
    requires mandated java.base;
    requires org.apiguardian.api;
    requires org.junit.jupiter.api;
    requires org.junit.platform.commons;
    requires org.junit.platform.engine;
    requires org.opentest4j;
  [Transitive reduced graph for org.junit.jupiter.engine]
    requires mandated java.base;
    requires org.junit.jupiter.api;
    requires org.junit.platform.engine;

sormuras · 2019-12-18T12:17:49Z

org.junit.jupiter.params

org.junit.jupiter.params (junit-jupiter-params-5.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.jupiter.api;
  [Suggested module descriptor for org.junit.jupiter.params]
    requires mandated java.base;
    requires java.sql;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.jupiter.api;
    requires transitive org.junit.platform.commons;
    requires unnamed;
java.lang.NullPointerException
	at jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)

https://github.com/sormuras/JDK-8225773/runs/354396352#step:4:62

sormuras · 2019-12-18T12:18:36Z

org.junit.platform.commons

org.junit.platform.commons (junit-platform-commons-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires java.logging;
    requires java.management;
    requires transitive org.apiguardian.api (@1.1.0);
  [Suggested module descriptor for org.junit.platform.commons]
    requires mandated java.base;
    requires java.logging;
    requires transitive org.apiguardian.api;
  [Transitive reduced graph for org.junit.platform.commons]
    requires mandated java.base;
    requires java.logging;
    requires transitive org.apiguardian.api;
  [Unused qualified exports in org.junit.platform.commons]
    exports org.junit.platform.commons.logging to org.junit.jupiter.migrationsupport,org.junit.jupiter.params,org.junit.platform.console,org.junit.platform.reporting,org.junit.platform.runner,org.junit.platform.suite.api
    exports org.junit.platform.commons.util to org.junit.platform.suite.api

sormuras · 2019-12-18T12:35:10Z

org.junit.platform.console

1.5.2 NPE https://github.com/sormuras/JDK-8225773/runs/354353926#step:4:52
1.6.0-M1 works (but why?) -- see result below:

org.junit.platform.console (junit-platform-console-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.platform.reporting;
  [Suggested module descriptor for org.junit.platform.console]
    requires mandated java.base;
    requires org.apiguardian.api;
    requires org.junit.platform.commons;
    requires org.junit.platform.engine;
    requires org.junit.platform.launcher;
    requires org.junit.platform.reporting;
  [Transitive reduced graph for org.junit.platform.console]
    requires mandated java.base;
    requires org.junit.platform.reporting;

sormuras · 2019-12-18T12:41:29Z

org.junit.platform.engine

org.junit.platform.engine (junit-platform-engine-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.platform.commons;
    requires transitive org.opentest4j (@1.2.0);
  [Suggested module descriptor for org.junit.platform.engine]
    requires mandated java.base;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.platform.commons;
    requires transitive org.opentest4j;
  [Transitive reduced graph for org.junit.platform.engine]
    requires mandated java.base;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.platform.commons;
    requires transitive org.opentest4j;

sormuras · 2019-12-18T12:42:15Z

org.junit.platform.launcher

org.junit.platform.launcher (junit-platform-launcher-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires java.logging;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.platform.engine;
  [Suggested module descriptor for org.junit.platform.launcher]
    requires mandated java.base;
    requires transitive java.logging;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.platform.commons;
    requires transitive org.junit.platform.engine;
  [Transitive reduced graph for org.junit.platform.launcher]
    requires mandated java.base;
    requires transitive java.logging;
    requires transitive org.apiguardian.api;
    requires transitive org.junit.platform.commons;
    requires transitive org.junit.platform.engine;

sormuras · 2019-12-18T12:43:01Z

org.junit.platform.reporting

org.junit.platform.reporting (junit-platform-reporting-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires java.xml;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.platform.launcher;
  [Suggested module descriptor for org.junit.platform.reporting]
    requires mandated java.base;
    requires java.xml;
    requires org.apiguardian.api;
    requires org.junit.platform.commons;
    requires transitive org.junit.platform.engine;
    requires transitive org.junit.platform.launcher;
  [Transitive reduced graph for org.junit.platform.reporting]
    requires mandated java.base;
    requires java.xml;
    requires transitive org.junit.platform.engine;
    requires transitive org.junit.platform.launcher;

sormuras · 2019-12-18T12:44:09Z

org.junit.platform.suite.api

org.junit.platform.suite.api (junit-platform-suite-api-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive org.apiguardian.api (@1.1.0);
  [Suggested module descriptor for org.junit.platform.suite.api]
    requires mandated java.base;
    requires org.apiguardian.api;
  [Transitive reduced graph for org.junit.platform.suite.api]
    requires mandated java.base;
    requires org.apiguardian.api;

sormuras · 2019-12-18T12:47:46Z

org.junit.platform.testkit

org.junit.platform.testkit (junit-platform-testkit-1.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires java.instrument;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.assertj.core;
    requires transitive org.junit.platform.launcher;
    requires transitive org.opentest4j (@1.2.0);
  [Suggested module descriptor for org.junit.platform.testkit]
    requires mandated java.base;
    requires transitive org.apiguardian.api;
    requires transitive org.assertj.core;
    requires org.junit.platform.commons;
    requires transitive org.junit.platform.engine;
    requires org.junit.platform.launcher;
    requires org.opentest4j;
  [Transitive reduced graph for org.junit.platform.testkit]
    requires mandated java.base;
    requires transitive org.apiguardian.api;
    requires transitive org.assertj.core;
    requires transitive org.junit.platform.engine;
    requires org.junit.platform.launcher;

sormuras · 2019-12-18T12:58:43Z

I always forget this one... now, I can't sort into the other Jupiter modules above. 😈

org.junit.jupiter.migrationsupport

org.junit.jupiter.migrationsupport (junit-jupiter-migrationsupport-5.6.0-M1.jar)
  [Module descriptor]
    requires mandated java.base;
    requires transitive junit;
    requires transitive org.apiguardian.api (@1.1.0);
    requires transitive org.junit.jupiter.api;
  [Suggested module descriptor for org.junit.jupiter.migrationsupport]
    requires mandated java.base;
    requires transitive junit;
    requires org.apiguardian.api;
    requires transitive org.junit.jupiter.api;
    requires org.junit.platform.commons;
  [Transitive reduced graph for org.junit.jupiter.migrationsupport]
    requires mandated java.base;
    requires transitive junit;
    requires transitive org.junit.jupiter.api;

marcphilipp · 2019-12-19T14:11:04Z

"Suggested module descriptors" LGTM.

Issue #2063

sormuras added type: task component: Jupiter component: Platform component: Vintage theme: modules labels Oct 14, 2019

sormuras added this to the 5.6 M2 milestone Oct 14, 2019

sormuras self-assigned this Oct 14, 2019

sormuras added a commit that referenced this issue Dec 5, 2019

Export "filter" package

c2a08f0

Issue #2063

sormuras mentioned this issue Dec 5, 2019

Revise module declarations #2121

Merged

7 tasks

sormuras added status: in progress and removed type: task labels Dec 5, 2019

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.vintage" group

04d458f

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.platform" group

a258aba

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Export "filter" package

93b80df

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.vintage" group

09a81ba

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.platform" group

461fe34

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.vintage" group

e3b2dc1

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.platform" group

f805ed8

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.jupiter" group

cd23615

Issue #2063

sormuras closed this as completed in #2121 Dec 20, 2019

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.vintage" group

2af5ed2

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.platform" group

c366d47

Issue #2063

sormuras added a commit that referenced this issue Dec 20, 2019

Revise module declarations of "org.junit.jupiter" group

1d88346

Issue #2063

sormuras removed the status: in progress label Jan 6, 2020

sormuras mentioned this issue Dec 9, 2020

Check and tune modular API AlmasB/FXGL#913

Closed

mkoncek mentioned this issue Mar 15, 2023

Drop transitive dependency on apiguardian #3193

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revise module declarations #2063

Revise module declarations #2063

sormuras commented Oct 14, 2019 •

edited

sormuras commented Dec 3, 2019 •

edited

sormuras commented Dec 5, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019 •

edited

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019 •

edited

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019

sormuras commented Dec 18, 2019 •

edited

marcphilipp commented Dec 19, 2019

Revise module declarations #2063

Revise module declarations #2063

Comments

sormuras commented Oct 14, 2019 • edited

Deliverables

sormuras commented Dec 3, 2019 • edited

sormuras commented Dec 5, 2019

Is transitive needed for requires transitive org.apiguardian.api;?

Is transitive needed for requires transitive org.opentest4j;?

sormuras commented Dec 18, 2019

org.junit.jupiter

sormuras commented Dec 18, 2019 • edited

org.junit.jupiter.api

sormuras commented Dec 18, 2019

org.junit.jupiter.engine

sormuras commented Dec 18, 2019 • edited

org.junit.jupiter.params

sormuras commented Dec 18, 2019

org.junit.platform.commons

sormuras commented Dec 18, 2019

org.junit.platform.console

sormuras commented Dec 18, 2019

org.junit.platform.engine

sormuras commented Dec 18, 2019

org.junit.platform.launcher

sormuras commented Dec 18, 2019

org.junit.platform.reporting

sormuras commented Dec 18, 2019

org.junit.platform.suite.api

sormuras commented Dec 18, 2019

org.junit.platform.testkit

sormuras commented Dec 18, 2019 • edited

org.junit.jupiter.migrationsupport

marcphilipp commented Dec 19, 2019

sormuras commented Oct 14, 2019 •

edited

sormuras commented Dec 3, 2019 •

edited

Is `transitive` needed for `requires transitive org.apiguardian.api;`?

Is `transitive` needed for `requires transitive org.opentest4j;`?

sormuras commented Dec 18, 2019 •

edited

sormuras commented Dec 18, 2019 •

edited

sormuras commented Dec 18, 2019 •

edited