Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom file system for @TempDir #2400

Closed
nipafx opened this issue Sep 8, 2020 · 9 comments · Fixed by #2958
Closed

Support custom file system for @TempDir #2400

nipafx opened this issue Sep 8, 2020 · 9 comments · Fixed by #2958

Comments

@nipafx
Copy link
Contributor

nipafx commented Sep 8, 2020

Jupiter's @TempDir does not allow the configuration of custom file systems. It would be nice if it would.

A key motivation for me to open this issue is that custom file systems are the only thing that Pioneer's @TempDir can do that Jupiter's can't. Since Jupiter's is quite a bit more powerful than ours now, we'd like to remove our extension (this also prevents confusion for users), but we don't feel comfortable doing that as long as there's a feature we offer that you don't.

If Jupiter isn't fundamentally opposed to such a feature, we could implement it and open a PR.

@marcphilipp
Copy link
Member

Team decision: Since the Extension backing Jupiter's @TempDir is currently registered globally, implementing this is not straightforward. In addition, at this time, we have not yet received great interest in such a feature within Jupiter itself. In light of that, we'd like to focus our resources on some of the more popular outstanding issues in Jupiter. If it later turns out that there's significant community interest to include it in Jupiter we may revisit this issue at that time.

@marcphilipp marcphilipp removed this from the 5.8 Backlog milestone Sep 11, 2020
@nipafx
Copy link
Contributor Author

nipafx commented Sep 11, 2020

Me:

If Jupiter isn't fundamentally opposed to such a feature, we could implement it and open a PR.

You:

we'd like to focus our resources on some of the more popular outstanding issues in Jupiter

Not sure how they relate. 😃 Should we (Pioneer) consider working on this to create a PR or would you prefer if we didn't?

@marcphilipp
Copy link
Member

Well, even if you put in the work to submit a PR we'd have to review it. Moreover, we would discuss how the API and implementation should roughly look like before that. So, for now, we'd prefer that you didn't. I hope you understand. 🙂

@nipafx
Copy link
Contributor Author

nipafx commented Sep 11, 2020

I hope you understand.

Of course, no worries. Just wanted to make sure.

@stale
Copy link

stale bot commented Sep 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label Sep 12, 2021
@jbduncan
Copy link
Contributor

I think this issue is valuable.

@marcphilipp
Copy link
Member

Now that @TempDir is created per declaration by default, that might make an approach that configures it locally feasible.

@scordio
Copy link
Contributor

scordio commented Apr 12, 2022

Although the custom file system could/will be specified per declaration, it'd still be useful to have a way to set it globally, for example with a configuration property (rationale at #2889 (comment)).

@scordio
Copy link
Contributor

scordio commented May 23, 2022

@marcphilipp @sbrannen is this up for grabs? I would like to work on it if that's fine with you.

@marcphilipp marcphilipp added this to the 5.10.0-M1 milestone Apr 24, 2023
@marcphilipp marcphilipp linked a pull request Apr 24, 2023 that will close this issue
9 tasks
marcphilipp pushed a commit that referenced this issue Apr 26, 2023
This adds a factory SPI to `@TempDir`, allowing to define how the
temporary directory is created.

This can be used for custom file systems, but it may also used for
customizing how and where the directory is created for the default file
system.

The intended usage is to extend `TempDirFactory` and provide the class
to the new `factory` attribute of `@TempDir`.

Resolves #2088.
Resolves #2400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants