Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate getting rid of external dependencies in junit-console #37

Closed
marcphilipp opened this issue Dec 3, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@marcphilipp
Copy link
Member

To be usable on the command-line, it would be nice if junit-console were a jar that includes all of its dependencies (fat-jar, uber-jar, ...).

@marcphilipp marcphilipp added this to the Alpha M1 milestone Dec 3, 2015
@marcphilipp marcphilipp self-assigned this Dec 3, 2015
marcphilipp added a commit that referenced this issue Dec 3, 2015
JOpt Simple has no dependencies.
@marcphilipp
Copy link
Member Author

I've discarded the fat-jar idea for now. I tried using the shadow Gradle plugin to relocate jopt-simple. However, jopt-simple uses ResourceBundles that are loaded from *.properties files where keys are prefixed with class names. Those would need to be transformed to reflect the relocation as well.

Instead I've used Gradle's application plugin to publish a ZIP and TAR archives that contain shell/batch scripts and all of the dependencies.

The content looks like this:
bildschirmfoto 2015-12-04 um 13 21 55


In addition, I think we should add a command-line option to ConsoleRunner that would allow to specify additional classpath entries and use a custom URLClassLoader.

@sbrannen
Copy link
Member

sbrannen commented Dec 4, 2015

I think the ZIP/TAR option is a viable alternative to a fat jar for the short term.

Regarding the additional classpath entries and a custom URLClassLoader, I would recommend you open separate issues to address those. If you do that, I think we could also go ahead and close this issue, since you've already made the switch to JOpt Simple.

marcphilipp added a commit that referenced this issue Dec 4, 2015
marcphilipp added a commit that referenced this issue Dec 4, 2015
marcphilipp added a commit that referenced this issue Dec 4, 2015
- Better separation of concerns
- Better testability
@marcphilipp
Copy link
Member Author

Work on a custom URLClassLoader continues in #50. In addition, I've started to write tests (to be continued in #49).

marcphilipp added a commit that referenced this issue Dec 4, 2015
marcphilipp added a commit that referenced this issue Dec 4, 2015
marcphilipp added a commit that referenced this issue Dec 4, 2015
- Better separation of concerns
- Better testability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants