Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Engine API package into subpackages #54

Closed
marcphilipp opened this issue Dec 11, 2015 · 2 comments
Closed

Split Engine API package into subpackages #54

marcphilipp opened this issue Dec 11, 2015 · 2 comments
Assignees
@mmerdes
Milestone
5.0 Alpha

Comments

@marcphilipp
Copy link
Member

Proposal

(not checked for package cycles etc., yet)

org.junit.gen5.engine.api

  • TestDescriptor
  • TestSource
  • TestTag
  • TestEngine
  • ExecutionRequest
  • EngineExecutionListener
  • EngineAwareTestDescriptor
  • discovery
    • AllTestsSpecification
    • ClassSpecification
    • ClassFilter
    • ClassFilters
    • ClassNameFilter
    • EngineFilter
    • MethodSpecification
    • PackageSpecification
    • TestPlanSpecification
    • TestPlanSpecificationElement
    • TestPlanSpecificationElementVisitor
    • UniqueIdSpecification
  • support
    • descriptor
      • AbstractTestDescriptor
      • EngineDescriptor
      • FileSystemSource
      • JavaSource
    • hierarchical
      • Container
      • EngineExecutionContext
      • HierarchicalTestEngine
      • HierarchicalTestExecutor
      • Leaf
@marcphilipp marcphilipp modified the milestones: ap, Alpha 1 Dec 11, 2015
@schauder
Copy link
Contributor

Not a fan of content in a package as plus subpackages, because it immediately brings up the question: What goes in the super package? If I have a class, that doesn't fit one of the existing subpackages, should I create a new subpackage, or put it in the super package.

Also *Filter seem to deal with detection of /search for tests, while *Specification sounds more like Specification of Test Execution, so these might belong in two different packages.

@mmerdes mmerdes self-assigned this Jan 13, 2016
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Move support classes to separate packages
0d2aa70 
Issue: #54
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Introduce EngineDiscoveryRequest and move Launcher-specific classes t…
5781696 
…o junit-launcher

Issue: #54
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Move discovery-related classes to separate package
3414201 
Issue: #54
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Rename support.discovery to support.descriptor
763cf50 
Issue: #54
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Remove RootTestDescriptor node from TestPlan
9da25e1 
Issue: #54
marcphilipp added a commit that referenced this issue Jan 18, 2016
@marcphilipp
Remove EngineAwareTestDescriptor
ab12dc8 
Issue: #54
bechte added a commit that referenced this issue Jan 18, 2016
@bechte
Cleanup JavaDoc and Polish
9339706 
Issue: #54
bechte added a commit that referenced this issue Jan 18, 2016
@bechte
Encapsulate Launcher with its support classes into main package
961fd47 
Issue: #54
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: Extracted new interface TestDiscoveryRequest from DiscoveryReque…
57b07e0 
…st and adapted usages
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: spotless
9dba31f
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: moved DiscoveryRequest and DiscoveryRequestBuilder to launcher.m…
92da20b 
…ain package
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: cleanup
df37664
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: removed method from DiscoveryRequest
7950664 
made DiscoveryRequest package private
mmerdes added a commit that referenced this issue Jan 19, 2016
@mmerdes
#54: polished TestDiscoveryRequest and EngineDiscoveryRequest
348a99c
jlink added a commit that referenced this issue Jan 19, 2016
@jlink
#54 Polishing Root
69d6e1d
@jlink
Copy link
Contributor

jlink commented Jan 21, 2016

Done in master.

@jlink jlink closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmerdes mmerdes

Labels
None yet
Projects
None yet
Milestone
5.0 Alpha
Development

No branches or pull requests
4 participants
@jlink @schauder @marcphilipp @mmerdes