Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ObjectArrayArguments.create() to arguments() #765

Closed
2 tasks done
sbrannen opened this issue Apr 3, 2017 · 2 comments
Closed
2 tasks done

Rename ObjectArrayArguments.create() to arguments() #765

sbrannen opened this issue Apr 3, 2017 · 2 comments
Assignees
@sbrannen
Labels
component: Jupiter theme: extensions type: enhancement
Milestone
5.0 M5

Comments

@sbrannen
Copy link
Member

sbrannen commented Apr 3, 2017 •
edited

Overview

In order to improve the user experience and allow for the static factory method in ObjectArrayArguments to be used via a static import, the name should be changed to something more DSL-like.

Deliverables

  • Rename ObjectArrayArguments.create() to arguments().
  • Rename ArgumentsProvider.arguments() to provideArguments().
@sbrannen sbrannen added this to the 5.0 M5 milestone Apr 3, 2017
@sbrannen sbrannen self-assigned this Apr 3, 2017
sbrannen added a commit that referenced this issue Apr 3, 2017
@sbrannen
Rename ObjectArrayArguments.create() to arguments()
30438b4 
Issue: #765
@sbrannen
Copy link
Member Author

sbrannen commented Apr 3, 2017

Resolved in 30438b4.

@sbrannen sbrannen closed this as completed Apr 3, 2017
sbrannen added a commit that referenced this issue Apr 3, 2017
@sbrannen
Rename ArgumentsProvider.arguments() to provideArguments()
c810d13 
Issue: #765
@sbrannen
Copy link
Member Author

sbrannen commented Apr 3, 2017

Further addressed in c810d13.

@sormuras sormuras mentioned this issue May 23, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
component: Jupiter theme: extensions type: enhancement
Projects
None yet
Milestone
5.0 M5
Development

No branches or pull requests
1 participant
@sbrannen