-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge [Container|Test]ExtensionContext into ExtensionContext #901
Comments
@junit-team/junit-lambda This issue is open for team discussion within the 5.0 M5 time frame. |
Thinking out loud... One thing I find at least slightly controversial about the proposal is the merging of I know that the same contextual information will available to extension authors; however, extension authors may wish to implement entirely different logic for the container level and the test level. Perhaps it's a non-issue, but it's definitely something to keep in mind. This of course ties into any decision made in conjunction with #625. |
Added a sub-deliverable regarding |
in progress |
The merge of `TestExecutionCondition` and `ContainerExecutionCondition` to `ExecutionCondition` caused compile errors in `OsCondition` and related classes and tests. This is now fixed. Upstream issue: junit-team/junit5#901
Overview
ConatinerExtensionContext
is already just a marker interface, and with the changes being introduced in #419 theTestExtensionContext
will soon contain a singleOptional<Throwable> getTestException()
method.With these points in mind, now may be an opportune time to take the plunge and completely remove both the
ConatinerExtensionContext
andTestExtensionContext
APIs and allow extension authors to rely solely on theExtensionContext
API.Related Issues
Deliverables
getTestException()
fromTestExtensionContext
toExtensionContext
.getTestException()
togetExecutionException()
in preparation for Introduce support for tracking exceptions thrown at the container level #899.ContainerExtensionContext
API.TestExtensionContext
API.ContainerExecutionCondition
andTestExecutionCondition
into a single, general purposeExecutionCondition
whose method accepts a soleExtensionContext
argument.The text was updated successfully, but these errors were encountered: