Enable per-class test instance lifecycle mode by default for Kotlin classes

[sbrannen]

Overview

Based on discussions in #905, we have decided to use @TestInstance(Lifecycle.PER_CLASS) by default for test classes written in Kotlin.

Implementation Notes

The following utility (courtesy of @sdeleuze) can be added to ReflectionUtils for detecting Kotlin classes without any external dependencies.

public static boolean isKotlinClass(Class<?> clazz) {
	for (Annotation annotation : clazz.getDeclaredAnnotations()) {
		if (annotation.annotationType().getName().equals("kotlin.Metadata")) {
			return true;
		}
	}
	return false;
}

Deliverables

• Use Lifecycle.PER_CLASS as the test instance lifecycle mode by default for test classes written in Kotlin.
• Document in User Guide and Release Notes.

[marcphilipp]

in progress

[marcphilipp]

Reopening this issue because the change still needs to be documented in User Guide and Release Notes.

[JLLeitschuh]

I don't agree with this decision. It seems like something that will lead to very confusing behaviour and seems to go against the Junit paradigm.
#905 (comment)

[mlevison]

Like @JLeitschuh I'm troubled and feel it doesn't fit the paradigm. What happens if there is a mixed language project - team members have to remember to mentally switch semantics. I myself would prefer a code based solution - i.e. Declare a static variable TEST_LIFECYCLE; If doesn't exist the default JUnit semantics exist; if does exist the declared semantics are used. I'm always troubled by config files because people often forget to look there. At least the code based approach has slight better visibility. Cheers Mark

…

On Tue, Aug 1, 2017 at 12:34 PM, Jonathan Leitschuh < ***@***.***> wrote: I don't agree with this decision. It seems like something that will lead to very confusing behaviour and seems to go against the Junit paradigm. #905 (comment) <#905 (comment)> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#991 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAImZshS5ccKpRU0CDbx-goz3Xw4vQNMks5sT1OggaJpZM4OmhDD> .

-- [image: headshot-square-300x300] <http://www.flickr.com/photos/36331075@N00/9674877046/> *Mark Levison* | 1 (877) 248-8277 | Twitter <https://twitter.com/mlevison> | LinkedIn <http://ca.linkedin.com/in/marklevison> | Facebook <https://www.facebook.com/agilepainrelief> Certified ScrumMaster Training: Vancouver <http://agilepainrelief.com/courses/vancouver> | Edmonton <http://agilepainrelief.com/courses/edmonton> | Ottawa <http://agilepainrelief.com/courses/ottawa> | Montreal <http://agilepainrelief.com/courses/montreal> | Toronto <http://agilepainrelief.com/courses/toronto> Certified Product Owner & Private Training also available ~ Our Training Schedule <http://agilepainrelief.com/courses/certified-scrum-agile-training> Agile Pain Relief Consulting <http://agilepainrelief.com/> | Notes from a Tool User <http://agilepainrelief.com/notesfromatooluser> Proud Sponsor of Agile Tour Gatineau Ottawa <http://goagiletour.ca/> and Agile Coach Camp Canada <http://agilecoachcampcanada.wordpress.com/>

[marcphilipp]

Let's continue the discussion in #905.