Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/temp dir cleanup #2729

Merged
merged 57 commits into from Nov 29, 2021
Merged

Feature/temp dir cleanup #2729

merged 57 commits into from Nov 29, 2021

Commits on Sep 25, 2021

  1. Add TempDirCleanupStrategy, and plumb into config, and tests.

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    71d885e View commit details
    Browse the repository at this point in the history

  2. Fix style problem

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    b90db93 View commit details
    Browse the repository at this point in the history

  3. Fix style problem

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    dca9fca View commit details
    Browse the repository at this point in the history

  4. Set a default value for the cleanup mode of ALWAYS

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    900ec13 View commit details
    Browse the repository at this point in the history

  5. Rename to TempDirStrategy to provide for more potential flexibility o… 

    …f use
    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    5c6028c View commit details
    Browse the repository at this point in the history

  6. Spotless fix of * imports

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    d295303 View commit details
    Browse the repository at this point in the history

  7. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    2242f47 View commit details
    Browse the repository at this point in the history

  8. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    3019634 View commit details
    Browse the repository at this point in the history

  9. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    313fd6b View commit details
    Browse the repository at this point in the history

  10. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    e596f0b View commit details
    Browse the repository at this point in the history

  11. Get Always and Never tests passing

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    118ffe7 View commit details
    Browse the repository at this point in the history

  12. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    ed98bc1 View commit details
    Browse the repository at this point in the history

  13. Spotless fix of indentation

    Harry Glasgow committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    476ba11 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Move to version 5.9

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    099aed9 View commit details
    Browse the repository at this point in the history

  2. Prevent TempDirStrategy annotations from being added to inner classes… 

    …, as this could lead to indeterminate cleanup mode
    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    ede3aee View commit details
    Browse the repository at this point in the history

  3. Allow TempDirStrategy annotations from being added to inner classes, … 

    …it works just fine
    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4934c90 View commit details
    Browse the repository at this point in the history

  4. Remove ON_SUCCESS cleanup mode, and add demo test for documentation

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    5209310 View commit details
    Browse the repository at this point in the history

  5. Add lifecycle tests for temp directory cleanup in different modes

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    73821e6 View commit details
    Browse the repository at this point in the history

  6. Add lifecycle tests for temp directory cleanup of nested tests

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    bbfdf18 View commit details
    Browse the repository at this point in the history

  7. Add documentation for TempDirStrategy

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    87e2be1 View commit details
    Browse the repository at this point in the history

  8. Use static imports of CleanupMode

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    2c63046 View commit details
    Browse the repository at this point in the history

  9. Apply spotless corrections

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    29e4d0e View commit details
    Browse the repository at this point in the history

  10. Documentation of the cleanup.mode.default configuration parameter

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    a15cae6 View commit details
    Browse the repository at this point in the history

  11. Documentation; configuration parameters link

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    eafc5c1 View commit details
    Browse the repository at this point in the history

  12. Fix @API problem

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    1fc600c View commit details
    Browse the repository at this point in the history

  13. Fix @API problem

    Harry Glasgow committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4dcaef5 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. Move to CleanupMode parameter in TempDir.

    Harry Glasgow committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    5b09b66 View commit details
    Browse the repository at this point in the history

  2. Typo

    Harry Glasgow committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    90d2a75 View commit details
    Browse the repository at this point in the history

  3. Make CloseablePath responsive to ON_SUCCESS, and unit test.

    Harry Glasgow committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    f9e67f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Set cleanup mode for injected TempDir fields, and tests.

    Harry Glasgow committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    13abd0d View commit details
    Browse the repository at this point in the history

  2. Rename

    Harry Glasgow committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    6ce9387 View commit details
    Browse the repository at this point in the history

  3. Add API annotation to CleanupMode

    Harry Glasgow committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    e6363b7 View commit details
    Browse the repository at this point in the history

  4. Spotless

    Harry Glasgow committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    bf1fdf4 View commit details
    Browse the repository at this point in the history

  5. Use configured cleanup mode if none defined.

    Harry Glasgow committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    47a9655 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2021

  1. Final polish

    Harry Glasgow committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    5e8c72e View commit details
    Browse the repository at this point in the history

  2. Address easy parts of review changes

    Harry Glasgow committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    825991a View commit details
    Browse the repository at this point in the history

  3. AnnotationSupport fix

    Harry Glasgow committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    da487dc View commit details
    Browse the repository at this point in the history

  4. Better parameter resolution, and test.

    Harry Glasgow committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    056f08d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. Inject and use JupiterConfiguration

    Harry Glasgow committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    5b4451c View commit details
    Browse the repository at this point in the history

  2. Move DEFAULT_TEST_CLASS_ORDER_PROPERTY_NAME

    Harry Glasgow committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    0fa4415 View commit details
    Browse the repository at this point in the history

  3. Move DEFAULT_TEST_CLASS_ORDER_PROPERTY_NAME

    Harry Glasgow committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    90eeee2 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Fix accidental class rename, and update release documentation.

    Harry Glasgow committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    38ef09f View commit details
    Browse the repository at this point in the history

  2. Move TempDirectory out of stateless extension list.

    Harry Glasgow committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    66cec30 View commit details
    Browse the repository at this point in the history

  3. Cleanup test directories.

    Harry Glasgow committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    66577d9 View commit details
    Browse the repository at this point in the history

  4. Add TempDir parameter tests.

    Harry Glasgow committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    05afc2b View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Rework TempDirectoryParameterResolverTests using AbstractJupiterTestE… 

    …ngineTests.
    Harry Glasgow committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    33cd7e6 View commit details
    Browse the repository at this point in the history

  2. Retrigger build.

    Harry Glasgow committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    56118f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Retrigger build.

    Harry Glasgow committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    c32ccba View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Use nio for safer deletes.

    Harry Glasgow committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a18d400 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Update documentation/src/docs/asciidoc/release-notes/release-notes-5.… 

    …9.0-M1.adoc

Co-authored-by: Marc Philipp <marc@gradle.com>
    @marcphilipp
    Harry Glasgow and marcphilipp committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    05b5f17 View commit details
    Browse the repository at this point in the history

  2. Update documentation/src/docs/asciidoc/user-guide/writing-tests.adoc 

    Co-authored-by: Marc Philipp <marc@gradle.com>
    @marcphilipp
    Harry Glasgow and marcphilipp committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    1311ce0 View commit details
    Browse the repository at this point in the history

  3. Update documentation/src/docs/asciidoc/user-guide/writing-tests.adoc 

    Co-authored-by: Marc Philipp <marc@gradle.com>
    @marcphilipp
    Harry Glasgow and marcphilipp committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    9894363 View commit details
    Browse the repository at this point in the history

  4. Update junit-jupiter-engine/src/test/java/org/junit/jupiter/engine/ex… 

    …tension/TempDirectoryCleanupTests.java

Co-authored-by: Marc Philipp <marc@gradle.com>
    @marcphilipp
    Harry Glasgow and marcphilipp committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    7b6a36d View commit details
    Browse the repository at this point in the history

  5. Simplify parameter directory deletion.

    Harry Glasgow committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    32f9094 View commit details
    Browse the repository at this point in the history

  6. Simplify closeable path deletion.

    Harry Glasgow committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    682463e View commit details
    Browse the repository at this point in the history

  7. Clean up the temp directory after use.

    Harry Glasgow committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    55aabfe View commit details
    Browse the repository at this point in the history

  8. Rerun build.

    Harry Glasgow committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    85493ee View commit details
    Browse the repository at this point in the history