Improve error message for non-static @MethodSource factory methods
#3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
changed the title
@MethodSource factory methods
marcphilipp
requested changes
Apr 22, 2023
...ter-params/src/test/java/org/junit/jupiter/params/provider/MethodArgumentsProviderTests.java
Outdated
Show resolved
Hide resolved
...-jupiter-params/src/main/java/org/junit/jupiter/params/provider/MethodArgumentsProvider.java
Outdated
Show resolved
Hide resolved
BassemElMasry
force-pushed
the
issue/3215
branch
2 times, most recently
from
f20963f
to
27c34b1
Compare
marcphilipp
approved these changes
Apr 26, 2023
|
Thank you for your contribution, @BassemElMasry! 👍 |
3 tasks
sbrannen
added a commit
that referenced
this pull request
Apr 28, 2023
Prior to this commit, the error message was cryptic if an external factory method was non-static and the test class was configured to run with test instance per-class lifecycle semantics. Specifically, the error was the following from the native implementation of Method#invoke in the JDK. java.lang.IllegalArgumentException: object is not an instance of declaring class This commit builds on the work done in PR #3263 by expanding the "static is required" check to any resolved factory method that cannot be invoked on the current test instance (which may be null). Consequently, the isPerMethodLifecycle() check is no longer necessary. Closes #3276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improve error message for non-static
@MethodSourcefactory methods.Currently, when a non-static method is required for test instance lifecycle
PER_METHOD, the error message thrown is unclear.issue: 3215
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations