Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @TempDir as a meta-annotation #3313

Closed

Conversation

marschall
Copy link
Contributor

@marschall marschall commented May 15, 2023

Overview

Add ANNOTATION_TYPE as a target to @TempDir to allow it to be used as a meta-annotation.

Issue: #3311


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marschall marschall marked this pull request as draft May 15, 2023 18:57
@marschall marschall force-pushed the TempDir-meta-annotation-capable branch from 9280787 to fa6224f Compare May 15, 2023 19:06
@marcphilipp marcphilipp linked an issue May 15, 2023 that may be closed by this pull request
1 task
@sbrannen sbrannen changed the title Make @TempDir meta annotation capable Support @TempDir as a meta-annotation May 16, 2023
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested a few minor changes.

A brief note in the User Guide stating that @TempDir can be used as a meta-annotation would be helpful, perhaps even with an example.

Please also add an entry in the release notes, or if you find that too cumbersome (since the release notes file does not yet exist) just let us know, and we'll add the release note entry after merging.

@marschall
Copy link
Contributor Author

I've requested a few minor changes.

Thanks for having a look.

A brief note in the User Guide stating that @TempDir can be used as a meta-annotation would be helpful, perhaps even with an example.

I added something. Let me know what you think.

Please also add an entry in the release notes, or if you find that too cumbersome (since the release notes file does not yet exist) just let us know, and we'll add the release note entry after merging.

I copy and pasted the template. I'm not sure whether I should add "No changes" or just "*" to the sections that are empty for now.

@marschall marschall marked this pull request as ready for review May 16, 2023 17:34
@marcphilipp marcphilipp requested a review from sbrannen May 17, 2023 16:00
Add ANNOTATION_TYPE as a target to @tempdir to allow it to be used in
meta annotations.

- change @tempdir
- update release notes
- update user guide with examples

Issue: junit-team#3311
@marschall marschall force-pushed the TempDir-meta-annotation-capable branch from c99d577 to b8422bf Compare May 23, 2023 18:59
@sbrannen sbrannen self-assigned this May 27, 2023
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.

Thanks! 👍

p.s. there's a slight issue with the terminology regarding "meta-annotation" vs. "composed annotation", but I'll address that after merging the PR.

@sbrannen sbrannen closed this in 6ae599b May 27, 2023
sbrannen added a commit that referenced this pull request May 27, 2023
@sbrannen
Copy link
Member

This has been merged into main in 6ae599b and revised in e205ccd.

Thanks

@marschall
Copy link
Contributor Author

Awesome, thanks a lot. Looking forward to RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @TempDir as a meta-annotation
3 participants