New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support @TempDir
as a meta-annotation
#3313
Support @TempDir
as a meta-annotation
#3313
Conversation
9280787
to
fa6224f
Compare
@TempDir
as a meta-annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested a few minor changes.
A brief note in the User Guide stating that @TempDir
can be used as a meta-annotation would be helpful, perhaps even with an example.
Please also add an entry in the release notes, or if you find that too cumbersome (since the release notes file does not yet exist) just let us know, and we'll add the release note entry after merging.
...ngine/src/test/java/org/junit/jupiter/engine/extension/TempDirectoryMetaAnnotationTests.java
Outdated
Show resolved
Hide resolved
...ngine/src/test/java/org/junit/jupiter/engine/extension/TempDirectoryMetaAnnotationTests.java
Outdated
Show resolved
Hide resolved
...ngine/src/test/java/org/junit/jupiter/engine/extension/TempDirectoryMetaAnnotationTests.java
Show resolved
Hide resolved
b53b6b0
to
c99d577
Compare
Thanks for having a look.
I added something. Let me know what you think.
I copy and pasted the template. I'm not sure whether I should add "No changes" or just "*" to the sections that are empty for now. |
Add ANNOTATION_TYPE as a target to @tempdir to allow it to be used in meta annotations. - change @tempdir - update release notes - update user guide with examples Issue: junit-team#3311
c99d577
to
b8422bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now.
Thanks! 👍
p.s. there's a slight issue with the terminology regarding "meta-annotation" vs. "composed annotation", but I'll address that after merging the PR.
Awesome, thanks a lot. Looking forward to RC1 |
Overview
Add
ANNOTATION_TYPE
as a target to@TempDir
to allow it to be used as a meta-annotation.Issue: #3311
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations