Fix parsing of recursive JAR URIs in CloseablePath

[mpkorstanje]

Overview

Jar uris follow the format[1]:

jar:<url>!/[<entry>]

So splitting should be done on the last !/ rather than the first.

Fixes: #1724 for Spring Boot 3.2 and later.

1. https://docs.oracle.com/javase/8/docs/api/java/net/JarURLConnection.html

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[mpkorstanje]

Verified end-2-end using https://github.com/mpkorstanje/junit-5-spring-boot-3.2.0.

[sbrannen]

Thanks for the PR, @mpkorstanje. 👍

Any chance you want to make nested JAR scanning work for Spring Boot versions prior to Spring Boot 3.2 as well (in a separate PR)? 😎

[mpkorstanje]

Any chance you want to make nested JAR scanning work for Spring Boot versions prior to Spring Boot 3.2 as well (in a separate PR)? 😎

The general case? No chance. 😄

Spring Boot 3.1 has only 6 months of OSS support left. For the amount of effort involved, it would be gilding a dead lilly.

The specific case of supporting scanning of /BOOT-INF/classes isn't too difficult. That mostly depends on how much of a code blister you're willing to accept. I've put a proposal in #1724 (comment). If that doesn't look too bad, I could polish it up into a PR.

[marcphilipp]

@mpkorstanje Thanks! 👍