Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection issue on JDK 8 for synthetic bridge methods #3798

Merged
merged 2 commits into from Apr 29, 2024

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Apr 28, 2024

By enabling -parameters their names are written to the compiled bytecode in addition to the synthetic flag thereby avoiding to trip up the Method#getParameters API when running on JDK 8.

Fixes #3797.

@marcphilipp marcphilipp force-pushed the marc/3797-bridge-method-reproducer branch from 0b5f117 to b0636b0 Compare April 29, 2024 07:08
@marcphilipp marcphilipp changed the title Add reproducer for JDK 8 bridge method issue Fix reflection issue on JDK 8 for synthetic bridge methods Apr 29, 2024
@marcphilipp marcphilipp marked this pull request as ready for review April 29, 2024 07:11
@marcphilipp marcphilipp force-pushed the marc/3797-bridge-method-reproducer branch from b0636b0 to 04a82b6 Compare April 29, 2024 07:16
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build change and test looks good to me.

@sormuras sormuras modified the milestone: 5.11 M2 Apr 29, 2024
@marcphilipp marcphilipp merged commit c8e1c6e into main Apr 29, 2024
14 checks passed
@marcphilipp marcphilipp deleted the marc/3797-bridge-method-reproducer branch April 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MalformedParametersException on JDK 8 for synthetic bridge methods in Jupiter classes (5.11.0-M1)
3 participants