Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what branch to edit when contributing #12

Closed
waldyrious opened this issue Dec 28, 2016 · 5 comments
Closed

Document what branch to edit when contributing #12

waldyrious opened this issue Dec 28, 2016 · 5 comments

Comments

@waldyrious
Copy link
Contributor

I came here to propose a change from Ctrl+, to Ctrl+, or Ctrl + , in installation.md, because the comma is easy to miss next to the plus sign, but I wasn't able to figure out what branch one is supposed to edit from the instructions in the README. Both master and gh-pages seem to have been edited recently, so it isn't clear which one should be edited.

In any case, it's always nicer to be explicit :)

@pfitzseb
Copy link
Member

Should be better now :)

@waldyrious
Copy link
Contributor Author

Thanks for the quick reaction! For reference, the relevant commit is 278e93c.

@waldyrious
Copy link
Contributor Author

waldyrious commented Dec 28, 2016

Out of curiosity, what is the gh-pages branch for? Is it populated by Documenter.jl?

@pfitzseb
Copy link
Member

Exactly. Have a look at this if you wanna know more about it.

@waldyrious
Copy link
Contributor Author

Thanks :)

ChrisRackauckas added a commit that referenced this issue Dec 28, 2016
add some details about the build process (cf. #12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants