-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for useful changes on other forks #15
Comments
Some interesting changes
|
This commit is extremely more performant on Android. PipedInputStream just doesn't work that well for us. |
Adding
|
Added geometer/junrar@c44496d changes |
Added META-INF/vfs-providers.xml |
@rednoah Would you be able to provide some context on this ? I don't really know VFS nor what it brings. I was thinking of removing it, but if it's useful we can keep it? |
@gotson This was already added by @beothorn (see the linked commit above his comment) |
I know, i'm wondering what's the use and if we should keep it or remove it. |
Someone a long time ago wanted to use junrar from inside a hadoop cluster. I don't think that this is a common usage and there are probably other ways to work around this without vfs. |
vsubhash/junrar@9831bed is breaking tests. Some of our test files do have windows separators, and extract fine on Mac and Linux, so this is probably not needed. |
It seems there is some interesting change here about PPM error handling, but i have no idea if those changes make sense or not. Files concerned:
|
Some more changes that are difficult to assess: phax/junrar@2b0dc09 |
And this one too: vaemendis@28663a4 |
I finished combing the changes listed above. I found only 3 that i cannot really assess (the 3 comments directly above this one). @sunny-shu if you are up to the challenge, you can have a look at the 3 changes and see if they make sense, and if yes we can port them to our version. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Because the main project is unmaintained there is a lot of fragmentation.
Lots of forks with different improvements https://github.com/edmund-wagner/junrar/network/members
It would be nice to scan them and reproduce improvements on this fork.
The text was updated successfully, but these errors were encountered: