Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum needed Java version #20

Closed
theobisproject opened this issue Aug 30, 2018 · 4 comments
Closed

Minimum needed Java version #20

theobisproject opened this issue Aug 30, 2018 · 4 comments
Labels

Comments

@theobisproject
Copy link
Contributor

I am a bit confused about which is the minimum Java version requirement for Junrar. The version in the pom.xml for the maven-compiler plugin is Java 6 (source and target) but the apache-vfs dependency states that the minimum Java version for 2.2 is Java 7 (see https://commons.apache.org/proper/commons-vfs/).
Was the version of apache-vfs raised on purpose to require Java 7 for Junrar and the changes for the maven-compiler-plugin forgotten or did this happen on accident?

@gotson
Copy link
Member

gotson commented Jul 16, 2020

I am looking at this now, I don't quite understand why there is VFS in the first place. I think it makes sense to remove it completely from the project. Do you have any view on that ?

I also plan to raise the minimum requirements to Java 8, since Java 6 is EOL and even the extended support has been dropped. Java 7 is still supported with extended support from Oracle until 2022, but now that Java 11 is LTS, and Java 8 is already considered legacy, a minimum of Java 8 should be more than enough.

@theobisproject
Copy link
Contributor Author

First: I don't use the VFS integration but if it is there some people will definitely do. For me it's more a not needed dependency in the project.
I personally would think about extracting the vfs integration into his own submodule and publish a junrar-vfs.jar. So "core" RAR implementation doesn't have this dependency any more.

@gotson
Copy link
Member

gotson commented Jul 16, 2020

First: I don't use the VFS integration but if it is there some people will definitely do. For me it's more a not needed dependency in the project.
I personally would think about extracting the vfs integration into his own submodule and publish a junrar-vfs.jar. So "core" RAR implementation doesn't have this dependency any more.

Thanks, that is a good idea. I will create a separate issue and see how we can do that.

gotson added a commit that referenced this issue Jul 18, 2020
remove checkstyle

BREAKING CHANGE: minimum java version bumped from 6 to 8

Closes #20
@gotson gotson closed this as completed in 9aa5794 Jul 18, 2020
gotson pushed a commit that referenced this issue Jul 18, 2020
# [5.0.0](v4.0.0...v5.0.0) (2020-07-18)

### Bug Fixes

* nullPointerException on corrupt headers ([b721589](b721589)), closes [#36](#36) [#45](#45)

### Build System

* use gradle instead of maven ([9aa5794](9aa5794)), closes [#20](#20)

### Code Refactoring

* remove VFS support ([3bbe8ed](3bbe8ed)), closes [#41](#41)

### BREAKING CHANGES

* carved-out into its own repo
* minimum java version bumped from 6 to 8
gotson pushed a commit that referenced this issue Jul 18, 2020
# [5.0.0](v4.0.0...v5.0.0) (2020-07-18)

### Bug Fixes

* nullPointerException on corrupt headers ([b721589](b721589)), closes [#36](#36) [#45](#45)

### Build System

* use gradle instead of maven ([9aa5794](9aa5794)), closes [#20](#20)

### Code Refactoring

* remove VFS support ([3bbe8ed](3bbe8ed)), closes [#41](#41)

### BREAKING CHANGES

* carved-out into its own repo
* minimum java version bumped from 6 to 8
@gotson
Copy link
Member

gotson commented Jul 18, 2020

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants