Remove exception handling from extractArchive #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the catches didn't permit to handle correctly any of the exceptions thrown during the process of extraction, it is better to throw them to the caller. At this level, it is not possible to know the handling strategy to use and this code should not handle them at all.
albertus82
added a commit
to albertus82/junrar
that referenced
this pull request
Jan 28, 2016
junrar#2 As the catches didn't permit to handle correctly any of the exceptions thrown during the process of extraction, it is better to throw them to the caller. At this level, it is not possible to know the handling strategy to use and this code should not handle them at all. alecharp
|
I use a zip file(aa.zip) rename to rar file(aa.rar), and then I use[Archive a = new Archive(new File("aa.rar"));], |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the catches didn't permit to handle correctly any of the exceptions
thrown during the process of extraction, it is better to throw them to
the caller. At this level, it is not possible to know the handling
strategy to use and this code should not handle them at all.