Fix multi-GPU runtime error with multi-scale netD #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #34 .
About the original issue: When
torch.nn.DataParallel
replicates aD_NLayersMulti
object to multiple devices, although all submodules are replicated,self.model
(which is an instance ofListModule
) is not replicated because PyTorch doesn't know how to copy it correctly. As a result, all replicatedD_NLayersMulti
instances haveself.model
pointing to the sameListModule
object whosemodule
attribute points to originalD_NLayersMulti
object before replication. You can checkid(self.model)
inD_NLayersMulti.forward
to verify it.I removed the usage of
ListModule
class, and madeD_NLayersMulti.forward
directly call submodule.