Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WOJAK #1586

Merged
merged 7 commits into from
Mar 13, 2024
Merged

WOJAK #1586

merged 7 commits into from
Mar 13, 2024

Conversation

Dh1988
Copy link
Contributor

@Dh1988 Dh1988 commented Feb 23, 2024

Validate WOJAK

Attestations (Please provide links):

Validation (Please check off boxes):

  • [ x] The metadata provided in the PR matches what is on-chain (Mandatory)
  • [x ] Does not duplicate the symbol of another token on Jupiter's strict list (If not, review will be delayed)
  • Is Listed on Coingecko / CMC (Optional, but helpful for reviewers)

Acknowledgement (Please check off boxes)

  • [ x] My change matches the format in the file (no spaces between fields).
  • [ x] My token is already live and trading on Jupiter.
  • [ x] !!! I read the README section on Community-Driven Validation and understand this PR will be only be reviewed when there is community support on Twitter.
  • [x ] Please make sure your pull request title has your token name. If it just says "Main", or "Validate", it will automatically be closed. PRs containing broken attestation or solscan links will also be closed.

@Dh1988
Copy link
Contributor Author

Dh1988 commented Feb 23, 2024

Changes are fine. Please go ahead with the pull request.

@Dh1988 Dh1988 marked this pull request as draft February 23, 2024 22:43
@Dh1988 Dh1988 marked this pull request as ready for review February 23, 2024 22:46
Lonelyboycrypto
Lonelyboycrypto reviewed Feb 24, 2024
View reviewed changes
Copy link

@Lonelyboycrypto Lonelyboycrypto left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to update WOJAKname

@Dh1988 Dh1988 closed this Feb 24, 2024
@Dh1988 Dh1988 reopened this Feb 24, 2024
Dh1988
Dh1988 commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@Dh1988 Dh1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited

Lonelyboycrypto
Lonelyboycrypto reviewed Feb 24, 2024
View reviewed changes
Copy link

@Lonelyboycrypto Lonelyboycrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now

@firstrank
Copy link

I support the pull request

firstrank
firstrank reviewed Feb 24, 2024
View reviewed changes
Copy link

@firstrank firstrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this.

@Jymfletzfur
Copy link
Collaborator

On chain name and ticker is Wojak

Submission is WOJAK

please amend

@Dh1988
Copy link
Contributor Author

Dh1988 commented Mar 9, 2024 •
edited

on chain name has been updated, thank you.

Lonelyboycrypto
Lonelyboycrypto reviewed Mar 9, 2024
View reviewed changes
Copy link

@Lonelyboycrypto Lonelyboycrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticker capitalization has been amended as per Jupiter's request.

firstrank
firstrank reviewed Mar 9, 2024
View reviewed changes
Copy link

@firstrank firstrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticker has been updated to be lower case. Please merge request.

@Dh1988
Copy link
Contributor Author

Dh1988 commented Mar 12, 2024

Hi I believe all conflicts are resolved the markers are all removed (deleted)

firstrank
firstrank reviewed Mar 12, 2024
View reviewed changes
Copy link

@firstrank firstrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Lonelyboycrypto
Lonelyboycrypto reviewed Mar 12, 2024
View reviewed changes
Copy link

@Lonelyboycrypto Lonelyboycrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@9yoi 9yoi requested review from 9yoi and Jymfletzfur March 13, 2024 17:02
@9yoi 9yoi merged commit 26e385c into jup-ag:main Mar 13, 2024
1 check failed
@Dh1988
Copy link
Contributor Author

Dh1988 commented Mar 13, 2024

Seems to be an issue with the link supplied for the logo image is it possible to send link and update or need to do a new pull request?

Thank you for the assistance also

@Dh1988
Copy link
Contributor Author

Dh1988 commented Mar 13, 2024

https://raw.githubusercontent.com/Lonelyboycrypto/Wojak/main/wojak-logo.png

this is the link I would like to use the other seems to have an issue with it

@Dh1988 Dh1988 mentioned this pull request Mar 14, 2024
Closed
Dh1988 added a commit to Dh1988/token-list that referenced this pull request Mar 16, 2024
@Dh1988
Revert "WOJAK (jup-ag#1586)"
a39e267 
This reverts commit 26e385c.
@Dh1988 Dh1988 mentioned this pull request Mar 16, 2024
Closed
vishalsinghji pushed a commit to vishalsinghji/token-list that referenced this pull request May 25, 2024
@Dh1988 @9yoi @vishalsinghji
WOJAK (jup-ag#1586)
a63f9b4 
* validate token

* Update validated-tokens.csv

Mended error

* Clean up format

---------

Co-authored-by: mei <15177990+9yoi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firstrank firstrank firstrank left review comments

@Lonelyboycrypto Lonelyboycrypto Lonelyboycrypto left review comments

@9yoi 9yoi 9yoi approved these changes

@Jymfletzfur Jymfletzfur Jymfletzfur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dh1988 @firstrank @Jymfletzfur @9yoi @Lonelyboycrypto