Enhancement: Add isOn() isOff()

[VonOx]

Description

• Type: Enhancement | Question

Enhancement

Suggested enhancement

Enhance power api like yamaha-nodejs

powerStatus return object like { PWR : true }

Implement or modify existing power api like yamaha package return:

onkyo.isOn()
onkyo.isOff()

What do you think about this feature ?

[jupe]

yamaha-nodejs implementation for isOn()/isOff() looks like it returns true/false depend on cached status - right ? in fact there is cache for these already - onkyo.deviceState.PWR -for example, which should tell if powers are on/off. I could add functions for it like you proposed :)

[VonOx]

Yes you are right.

I just think this is more natural, I have already implemented deviceState so this is not a problem right now.

Just an idea. Feel free to close this issue😉

[jupe]

sorry, I did it already and released to npm :D

[jupe]

I just looked a vit more deeply yamaha library and yes it is Promise api - it was wrapped to promise based here: https://github.com/PSeitz/yamaha-nodejs/blob/0bd1d83371061332a30bfefbb2f9d76c6c5002bf/simpleCommands.js#L452 .

So onkyo.js behaviours now a bit different than yamaha lib for isOn and isOff -functions. Perhaps I should switch that to Promise based - at least it is always up-to-date because no cached value needed..