Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Melpa Recipe for gitignore-mode #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New Melpa Recipe for gitignore-mode #6

wants to merge 1 commit into from

Conversation

BenedictHW
Copy link

Hey!

Just recently,
melpa/melpa@cc3a0ce,
was merged and

gitattributes-mode
gitconfig-mode
gitignore-mode

have been subsumed into one singular git-modes.

Have a good one,

gitattributes-mode
gitconfig-mode
gitignore-mode

have been combined into 'git-modes' in commit  melpa/melpa@cc3a0ce.

Additional context: syl20bnr/spacemacs#15117
@rogeric
Copy link

rogeric commented Oct 25, 2021

@HanshenWang could you help for the "develop" branch? That will be really really helpful! Thanks~

@jonBoone
Copy link

@rogeric -- what needs to be done to get this pull request merged? The current master branch causes errors for spacemacs users.

@tarsius
Copy link

tarsius commented Feb 7, 2023

what needs to be done to get this pull request merged?

Try contacting @jupl by email. Tell them if they don't want to maintain this package anymore, they can transfer it to the Emacs orphanage. (Because Github doesn't allow transfers to an organization by someone who is not a member, they would have to transfer to me, and I will then forward it.)

If we go down that path, I would merge this pull-request and do some other light maintenance work that may come up. I would also vet volunteers who would like to maintain this under the umbrella of the orphanage.

For more information about the Emacs orphanage and related projects, see https://github.com/emacsorphanage.

tarsius pushed a commit to emacsorphanage/helm-gitignore that referenced this pull request Mar 10, 2023
`gitignore-mode' is no longer distributed as a separate package.
It is now distributed as part of the `git-modes' package.  Depend
on the latter.

See melpa/melpa@cc3a0ce6c8a4a67b8a8d4b,
syl20bnr/spacemacs#15117
and jupl#6.
tarsius added a commit to melpa/melpa that referenced this pull request Mar 10, 2023
@tarsius
Copy link

tarsius commented Mar 10, 2023

I've added this package to the orphanage, merged this pr (with an improved commit message) and updated Melpa to use that fork.

As I mentioned I am willing to merge other pull-requests, such as #5 (ping @sei40kr). But I would appreciate help from people who actually use that package. So please review that pr, testing whether the change is desirable and whether it compiles without warnings. If you conclude that it is good for merge, then please open a new pr in my fork.

mhayashi1120 pushed a commit to mhayashi1120/melpa that referenced this pull request Apr 5, 2023
akirak pushed a commit to akirak/melpa that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants