Merge b738880 into 722d8d0

jupp0r · May 14, 2021 · 7b21cab · 7b21cab
2 parents 722d8d0 + b738880
commit 7b21cab
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/core/include/prometheus/detail/ckms_quantiles.h b/core/include/prometheus/detail/ckms_quantiles.h
@@ -15,21 +15,21 @@ namespace detail {
 class PROMETHEUS_CPP_CORE_EXPORT CKMSQuantiles {
  public:
   struct PROMETHEUS_CPP_CORE_EXPORT Quantile {
-    const double quantile;
-    const double error;
-    const double u;
-    const double v;
-
     Quantile(double quantile, double error);
+
+    double quantile;
+    double error;
+    double u;
+    double v;
   };
 
  private:
   struct Item {
-    /*const*/ double value;
+    double value;
     int g;
-    /*const*/ int delta;
+    int delta;
 
-    explicit Item(double value, int lower_delta, int delta);
+    Item(double value, int lower_delta, int delta);
   };
 
  public:

diff --git a/core/tests/summary_test.cc b/core/tests/summary_test.cc
@@ -92,5 +92,13 @@ TEST(SummaryTest, max_age) {
   test_value(std::numeric_limits<double>::quiet_NaN());
 }
 
+TEST(SummaryTest, construction_with_dynamic_quantile_vector) {
+  auto quantiles = Summary::Quantiles{{0.99, 0.001}};
+  quantiles.push_back({0.5, 0.05});
+
+  Summary summary{quantiles, std::chrono::seconds(1), 2};
+  summary.Observe(8.0);
+}
+
 }  // namespace
 }  // namespace prometheus