Separate symbol visibility for core, push, and pull

jupp0r · Aug 3, 2019 · eb9479c · eb9479c
1 parent ed7f79d
commit eb9479c
Show file tree

Hide file tree

Showing 26 changed files with 69 additions and 59 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -3,6 +3,7 @@ cmake_minimum_required(VERSION 3.5 FATAL_ERROR)
 
 project(prometheus-cpp VERSION 0.8.0)
 
+include(GenerateExportHeader)
 include(GNUInstallDirs)
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt
@@ -19,6 +19,11 @@ add_library(core
 
 add_library(${PROJECT_NAME}::core ALIAS core)
 
+generate_export_header(core
+  EXPORT_FILE_NAME include/prometheus/detail/core_export.h
+  PREFIX_NAME PROMETHEUS_CPP_
+)
+
 target_link_libraries(core
   PRIVATE
     Threads::Threads
@@ -28,6 +33,7 @@ target_link_libraries(core
 target_include_directories(core
   PUBLIC
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+    $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>
 )
 
 set_target_properties(core
@@ -47,7 +53,7 @@ install(
 )
 
 install(
-  DIRECTORY include/
+  DIRECTORY include/ ${CMAKE_CURRENT_BINARY_DIR}/include/
   DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
 )
 

diff --git a/core/include/prometheus/check_names.h b/core/include/prometheus/check_names.h
@@ -2,10 +2,10 @@
 
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
-PROMETHEUSCPP_API bool CheckMetricName(const std::string& name);
-PROMETHEUSCPP_API bool CheckLabelName(const std::string& name);
+PROMETHEUS_CPP_CORE_EXPORT bool CheckMetricName(const std::string& name);
+PROMETHEUS_CPP_CORE_EXPORT bool CheckLabelName(const std::string& name);
 }  // namespace prometheus
diff --git a/core/include/prometheus/client_metric.h b/core/include/prometheus/client_metric.h
@@ -5,11 +5,11 @@
 #include <tuple>
 #include <vector>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
-struct PROMETHEUSCPP_API ClientMetric {
+struct PROMETHEUS_CPP_CORE_EXPORT ClientMetric {
   // Label
 
   struct Label {

diff --git a/core/include/prometheus/collectable.h b/core/include/prometheus/collectable.h
@@ -2,7 +2,7 @@
 
 #include <vector>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 struct MetricFamily;
@@ -14,7 +14,7 @@ namespace prometheus {
 /// collect metrics.
 ///
 /// A Collectable has to be registered for collection. See Registry.
-class PROMETHEUSCPP_API Collectable {
+class PROMETHEUS_CPP_CORE_EXPORT Collectable {
  public:
   virtual ~Collectable() = default;
 

diff --git a/core/include/prometheus/counter.h b/core/include/prometheus/counter.h
@@ -1,8 +1,8 @@
 #pragma once
 
 #include "prometheus/client_metric.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/counter_builder.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/gauge.h"
 #include "prometheus/metric_type.h"
 
@@ -23,7 +23,7 @@ namespace prometheus {
 ///
 /// The class is thread-safe. No concurrent call to any API of this type causes
 /// a data race.
-class PROMETHEUSCPP_API Counter {
+class PROMETHEUS_CPP_CORE_EXPORT Counter {
  public:
   static const MetricType metric_type{MetricType::Counter};
 
@@ -77,6 +77,6 @@ class PROMETHEUSCPP_API Counter {
 ///
 /// To finish the configuration of the Counter metric, register it with
 /// Register(Registry&).
-PROMETHEUSCPP_API detail::CounterBuilder BuildCounter();
+PROMETHEUS_CPP_CORE_EXPORT detail::CounterBuilder BuildCounter();
 
 }  // namespace prometheus
diff --git a/core/include/prometheus/detail/ckms_quantiles.h b/core/include/prometheus/detail/ckms_quantiles.h
@@ -5,12 +5,12 @@
 #include <functional>
 #include <vector>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 namespace detail {
 
-class PROMETHEUSCPP_API CKMSQuantiles {
+class PROMETHEUS_CPP_CORE_EXPORT CKMSQuantiles {
  public:
   struct Quantile {
     const double quantile;

diff --git a/core/include/prometheus/detail/counter_builder.h b/core/include/prometheus/detail/counter_builder.h
@@ -3,7 +3,7 @@
 #include <map>
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
@@ -14,7 +14,7 @@ class Registry;
 
 namespace detail {
 
-class PROMETHEUSCPP_API CounterBuilder {
+class PROMETHEUS_CPP_CORE_EXPORT CounterBuilder {
  public:
   CounterBuilder& Labels(const std::map<std::string, std::string>& labels);
   CounterBuilder& Name(const std::string&);

diff --git a/core/include/prometheus/detail/gauge_builder.h b/core/include/prometheus/detail/gauge_builder.h
@@ -3,7 +3,7 @@
 #include <map>
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
@@ -14,7 +14,7 @@ class Registry;
 
 namespace detail {
 
-class PROMETHEUSCPP_API GaugeBuilder {
+class PROMETHEUS_CPP_CORE_EXPORT GaugeBuilder {
  public:
   GaugeBuilder& Labels(const std::map<std::string, std::string>& labels);
   GaugeBuilder& Name(const std::string&);

diff --git a/core/include/prometheus/detail/histogram_builder.h b/core/include/prometheus/detail/histogram_builder.h
@@ -3,7 +3,7 @@
 #include <map>
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
@@ -14,7 +14,7 @@ class Registry;
 
 namespace detail {
 
-class PROMETHEUSCPP_API HistogramBuilder {
+class PROMETHEUS_CPP_CORE_EXPORT HistogramBuilder {
  public:
   HistogramBuilder& Labels(const std::map<std::string, std::string>& labels);
   HistogramBuilder& Name(const std::string&);

diff --git a/core/include/prometheus/detail/summary_builder.h b/core/include/prometheus/detail/summary_builder.h
@@ -3,7 +3,7 @@
 #include <map>
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
@@ -14,7 +14,7 @@ class Registry;
 
 namespace detail {
 
-class PROMETHEUSCPP_API SummaryBuilder {
+class PROMETHEUS_CPP_CORE_EXPORT SummaryBuilder {
  public:
   SummaryBuilder& Labels(const std::map<std::string, std::string>& labels);
   SummaryBuilder& Name(const std::string&);

diff --git a/core/include/prometheus/detail/time_window_quantiles.h b/core/include/prometheus/detail/time_window_quantiles.h
@@ -5,12 +5,12 @@
 #include <vector>
 
 #include "prometheus/detail/ckms_quantiles.h"
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 namespace detail {
 
-class PROMETHEUSCPP_API TimeWindowQuantiles {
+class PROMETHEUS_CPP_CORE_EXPORT TimeWindowQuantiles {
   using Clock = std::chrono::steady_clock;
 
  public:

diff --git a/core/include/prometheus/detail/utils.h b/core/include/prometheus/detail/utils.h
@@ -4,7 +4,7 @@
 #include <map>
 #include <string>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 
 namespace prometheus {
 
@@ -15,7 +15,7 @@ namespace detail {
 /// \param labels The map that will be computed the hash value.
 ///
 /// \returns The hash value of the given labels.
-PROMETHEUSCPP_API std::size_t hash_labels(
+PROMETHEUS_CPP_CORE_EXPORT std::size_t hash_labels(
     const std::map<std::string, std::string>& labels);
 
 }  // namespace detail

diff --git a/core/include/prometheus/detail/visibility.h b/core/include/prometheus/detail/visibility.h
diff --git a/core/include/prometheus/family.h b/core/include/prometheus/family.h
@@ -15,9 +15,9 @@
 #include "prometheus/check_names.h"
 #include "prometheus/client_metric.h"
 #include "prometheus/collectable.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/future_std.h"
 #include "prometheus/detail/utils.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/metric_family.h"
 
 namespace prometheus {
@@ -59,7 +59,7 @@ namespace prometheus {
 ///
 /// \tparam T One of the metric types Counter, Gauge, Histogram or Summary.
 template <typename T>
-class PROMETHEUSCPP_API Family : public Collectable {
+class PROMETHEUS_CPP_CORE_EXPORT Family : public Collectable {
  public:
   /// \brief Create a new metric.
   ///

diff --git a/core/include/prometheus/gauge.h b/core/include/prometheus/gauge.h
@@ -3,8 +3,8 @@
 #include <atomic>
 
 #include "prometheus/client_metric.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/gauge_builder.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/metric_type.h"
 
 namespace prometheus {
@@ -21,7 +21,7 @@ namespace prometheus {
 ///
 /// The class is thread-safe. No concurrent call to any API of this type causes
 /// a data race.
-class PROMETHEUSCPP_API Gauge {
+class PROMETHEUS_CPP_CORE_EXPORT Gauge {
  public:
   static const MetricType metric_type{MetricType::Gauge};
 
@@ -89,6 +89,6 @@ class PROMETHEUSCPP_API Gauge {
 ///
 /// To finish the configuration of the Gauge metric register it with
 /// Register(Registry&).
-PROMETHEUSCPP_API detail::GaugeBuilder BuildGauge();
+PROMETHEUS_CPP_CORE_EXPORT detail::GaugeBuilder BuildGauge();
 
 }  // namespace prometheus
diff --git a/core/include/prometheus/histogram.h b/core/include/prometheus/histogram.h
@@ -4,8 +4,8 @@
 
 #include "prometheus/client_metric.h"
 #include "prometheus/counter.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/histogram_builder.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/metric_type.h"
 
 namespace prometheus {
@@ -26,7 +26,7 @@ namespace prometheus {
 ///
 /// The class is thread-safe. No concurrent call to any API of this type causes
 /// a data race.
-class PROMETHEUSCPP_API Histogram {
+class PROMETHEUS_CPP_CORE_EXPORT Histogram {
  public:
   using BucketBoundaries = std::vector<double>;
 
@@ -90,6 +90,6 @@ class PROMETHEUSCPP_API Histogram {
 ///
 /// To finish the configuration of the Histogram metric register it with
 /// Register(Registry&).
-PROMETHEUSCPP_API detail::HistogramBuilder BuildHistogram();
+PROMETHEUS_CPP_CORE_EXPORT detail::HistogramBuilder BuildHistogram();
 
 }  // namespace prometheus
diff --git a/core/include/prometheus/metric_family.h b/core/include/prometheus/metric_family.h
@@ -4,12 +4,12 @@
 #include <vector>
 
 #include "prometheus/client_metric.h"
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/metric_type.h"
 
 namespace prometheus {
 
-struct PROMETHEUSCPP_API MetricFamily {
+struct PROMETHEUS_CPP_CORE_EXPORT MetricFamily {
   std::string name;
   std::string help;
   MetricType type = MetricType::Untyped;

diff --git a/core/include/prometheus/registry.h b/core/include/prometheus/registry.h
@@ -8,12 +8,12 @@
 
 #include "prometheus/collectable.h"
 #include "prometheus/counter.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/counter_builder.h"
 #include "prometheus/detail/future_std.h"
 #include "prometheus/detail/gauge_builder.h"
 #include "prometheus/detail/histogram_builder.h"
 #include "prometheus/detail/summary_builder.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/family.h"
 #include "prometheus/gauge.h"
 #include "prometheus/histogram.h"
@@ -35,7 +35,7 @@ namespace prometheus {
 ///
 /// The class is thread-safe. No concurrent call to any API of this type causes
 /// a data race.
-class PROMETHEUSCPP_API Registry : public Collectable {
+class PROMETHEUS_CPP_CORE_EXPORT Registry : public Collectable {
  public:
   /// \brief Returns a list of metrics and their samples.
   ///

diff --git a/core/include/prometheus/serializer.h b/core/include/prometheus/serializer.h
@@ -4,12 +4,12 @@
 #include <string>
 #include <vector>
 
-#include "prometheus/detail/visibility.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/metric_family.h"
 
 namespace prometheus {
 
-class PROMETHEUSCPP_API Serializer {
+class PROMETHEUS_CPP_CORE_EXPORT Serializer {
  public:
   virtual ~Serializer() = default;
   virtual std::string Serialize(const std::vector<MetricFamily>&) const;

diff --git a/core/include/prometheus/summary.h b/core/include/prometheus/summary.h
@@ -7,9 +7,9 @@
 
 #include "prometheus/client_metric.h"
 #include "prometheus/detail/ckms_quantiles.h"
+#include "prometheus/detail/core_export.h"
 #include "prometheus/detail/summary_builder.h"
 #include "prometheus/detail/time_window_quantiles.h"
-#include "prometheus/detail/visibility.h"
 #include "prometheus/metric_type.h"
 
 namespace prometheus {
@@ -38,7 +38,7 @@ namespace prometheus {
 ///
 /// The class is thread-safe. No concurrent call to any API of this type causes
 /// a data race.
-class PROMETHEUSCPP_API Summary {
+class PROMETHEUS_CPP_CORE_EXPORT Summary {
  public:
   using Quantiles = std::vector<detail::CKMSQuantiles::Quantile>;
 
@@ -118,6 +118,6 @@ class PROMETHEUSCPP_API Summary {
 ///
 /// To finish the configuration of the Summary metric register it with
 /// Register(Registry&).
-PROMETHEUSCPP_API detail::SummaryBuilder BuildSummary();
+PROMETHEUS_CPP_CORE_EXPORT detail::SummaryBuilder BuildSummary();
 
 }  // namespace prometheus