about Registry::Add some question

[Marsmzhao-TX]

I noticed that inside the function template <typename T> Family<T>& Registry::Add(const std::string& name , const std::string& help ,const Labels& labels), the "same_name_and_labels" is returned using 'name' and 'labels' as keys.

However, later in the function, there is another duplication check using 'name' only as the key:

auto it = std::find_if(families.begin(), families.end(), same_name);
if (it != families.end()) {
  throw std::invalid_argument("Family name already exists");
}

I am considering whether the latter check can be removed to make the key of Family consist of both 'name' and 'labels'. Could this adjustment help better optimize the function?

[gjasny]

Hello,

you're right. In former times we had a third merge strategy. When it got removed, we did not optimize the code.
Could you please take a look at #673?

Thanks,
Gregor

[Marsmzhao-TX]

o(￣▽￣)ブ