Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional Shapes #42

Closed
dfreeman06 opened this issue Nov 12, 2020 · 1 comment · Fixed by #60
Closed

Support additional Shapes #42

dfreeman06 opened this issue Nov 12, 2020 · 1 comment · Fixed by #60
Projects

Comments

@dfreeman06
Copy link
Contributor

dfreeman06 commented Nov 12, 2020

  • e.g. circles / triangles
  • implications of edge connections
  • different arrowheads
@dfreeman06 dfreeman06 created this issue from a note in Planning (Features) Nov 12, 2020
@dfreeman06 dfreeman06 changed the title Support additional ElkNode Shapes Support additional Shapes Nov 12, 2020
@nrbgt
Copy link
Contributor

nrbgt commented Nov 12, 2020

Regarding ◀️ : doable, but require <defs><marker id="foo">, and can then be referenced in the style="marker-end:url(#foo)" of a path (or this can be set by css rules and classes, e.g. elk-line-marker-arrow-open).

Looks like we can overload SGraphView and inject the defs.

This would complicate offline SVG generation, which just blindly strips ids (as they weren't useful yet) but we can mark them with classes, e.g. class="elk-preserve-id".... or whitelist/mangle anything that appears in use(#*)

@dfreeman06 dfreeman06 linked a pull request Dec 15, 2020 that will close this issue
8 tasks
@dfreeman06 dfreeman06 moved this from Features to Next in Planning Dec 15, 2020
@dfreeman06 dfreeman06 moved this from Next to In progress in Planning Jan 6, 2021
@nrbgt nrbgt mentioned this issue Jan 12, 2021
14 tasks
@dfreeman06 dfreeman06 moved this from In progress to Done in Planning Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants