Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Custom defined Shapes #60

Merged
merged 41 commits into from
Jan 19, 2021
Merged

Adding Custom defined Shapes #60

merged 41 commits into from
Jan 19, 2021

Conversation

dfreeman06
Copy link
Contributor

@dfreeman06 dfreeman06 commented Dec 15, 2020 •
edited
Loading

  • Ability to add custom shapes to diagram svg
  • Custom shapes on ports
  • Custom connector end shapes for edges
  • Custom node shapes
  • Custom node label shapes
  • Widgets in nodes
  • Node compartments
  • Initial LOD check for labels

@dfreeman06 dfreeman06 linked an issue Dec 15, 2020 that may be closed by this pull request
Support additional Shapes #42
Closed
Dane Freeman added 23 commits December 15, 2020 16:48
fix import
1cf91e6
add missing header info
fb6eba1
still fixing that import
a214dd1
refactoring node property passing
280ae15
better logic gate example. more node view types
ac757a7
refactoring node and def views.
421809a
pre transformer/diagram split
81ca939
initial splitting of layout and diagram
75a0cd8
bump to elk 0.7.1
7fef06a
ipywidgets inside
491037e
cleanup styling and calculate widget div overlay for nested elements
31be586
only render overlay objects if in view
a057905
disable diagram panning if in a widget node
ffc4be3
css classes for ports in logic gate example. example of nesting diagr…
c1b4f5d 
…am inside a diagram
formatting
4f560da
fixing tests
82aa5d8
refactoring model renderer. ellipse node view centering
3e118f6
compound experiments
7c4e9ad
linting and header update
6f8b331
use node min size constraints for logic gate examples.
e9ce09a
update examples
3eacdcf
selfloop edge owner map to parent
ddbf9d3
merge port shape properties to element port
1f77e40
@nrbgt
Copy link
Contributor

nrbgt commented Jan 14, 2021

Going to re-kick...

@nrbgt nrbgt closed this Jan 14, 2021
@nrbgt nrbgt reopened this Jan 14, 2021
@nrbgt
Copy link
Contributor

nrbgt commented Jan 14, 2021

Still the same MacOS fail... since we don't really care, or have a good way to troubleshoot... I'm not against just "hiding" some more stuff on MacOS/Win CI... as long as it installs the production package, we're good...

@nrbgt nrbgt mentioned this pull request Jan 14, 2021
Merged
9 tasks
@nrbgt nrbgt mentioned this pull request Jan 15, 2021
Closed
@nrbgt
Copy link
Contributor

nrbgt commented Jan 19, 2021

Provided there's no crazy windows flake, I think we're good to go here... will approve once we're fully ✔️ ed

@nrbgt
Copy link
Contributor

nrbgt commented Jan 19, 2021

30dc023 did show that doing the solve against a dirty local cache can create issues... should probably hoist to a (new) preflight... e.g. does there appear a line in yarn.lock that:

  • starts with \s+resolved
  • doesn't contain "https://

nrbgt added a commit to nrbgt/ipyelk that referenced this pull request Jan 19, 2021
@nrbgt
backport schema fix from jupyrdf#60
499072b
@nrbgt
Copy link
Contributor

nrbgt commented Jan 19, 2021

e1e186d came up clean 🎉 but did go ahead and add the build preflight... not looking forward to the merge conflicts with #62 but we'll deal with that when we get there.

nrbgt
nrbgt approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@nrbgt nrbgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dfreeman06 dfreeman06 merged commit 25b1e3f into master Jan 19, 2021
@nrbgt nrbgt mentioned this pull request Jan 21, 2021
Closed
19 tasks
@dfreeman06 dfreeman06 deleted the gh_42_shapes branch January 21, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrbgt nrbgt nrbgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support additional Shapes
2 participants
@dfreeman06 @nrbgt