Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importnb #30

Merged
merged 15 commits into from
Oct 30, 2020
Merged

Add importnb #30

merged 15 commits into from
Oct 30, 2020

Conversation

nrbgt
Copy link
Contributor

@nrbgt nrbgt commented Oct 27, 2020

  • fixes use importnb for (functional) examples #28
  • add importnb, resolve envs
  • rework robot to require less copy/pasta
  • update examples to use importnb functional style
    • 00_Introduction.ipynb
    • 01_Linking.ipynb
    • 02_Transformer.ipynb
    • 03_App.ipynb
    • 04_Interactive.ipynb
    • 100_node_label_placement.ipynb
    • 101_text_sizer.ipynb
    • 102_layout_options.ipynb
    • 103_transformer_layout_options.ipynb

@nrbgt
Copy link
Contributor Author

nrbgt commented Oct 27, 2020

While this isn't fully done, getting it merged early-ish would help with e.g. confidently merging #24 into #27... if it's green, it's probably good to go.

@nrbgt
Copy link
Contributor Author

nrbgt commented Oct 28, 2020

Should be smoother sailing now that i just copy the whole examples into the test directory.

@nrbgt
Copy link
Contributor Author

nrbgt commented Oct 28, 2020

Looks like I really made windows angry somehow, but otherwise this is almost ready for review/merging for real.

@nrbgt nrbgt changed the title [wip] add importnb Add importnb Oct 29, 2020
@nrbgt nrbgt requested a review from dfreeman06 October 29, 2020 14:45
@nrbgt nrbgt mentioned this pull request Oct 29, 2020
6 tasks
@dfreeman06 dfreeman06 merged commit 6d1230c into jupyrdf:master Oct 30, 2020
@nrbgt nrbgt mentioned this pull request Oct 30, 2020
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use importnb for (functional) examples
2 participants