Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0 postmortem ☠️ #44

Merged
merged 7 commits into from
Nov 13, 2020
Merged

Conversation

nrbgt
Copy link
Contributor

@nrbgt nrbgt commented Nov 12, 2020

After #18, we noted a few things:

  • should generate SHA256SUMS during CI
  • the release verification was based on notebooks having been linted, which is pretty slow
  • starting to get some package drift
  • need to start a new version and changelog

This PR:

  • conservatively bumps the versions to 0.2.1, in case we find bugs-what-need-fixen
  • adds a build:hash task to generate SHA256SUMS file
    • skipped on windows, shells out to sha256sum
  • moves the nbconvert output to build
  • reworks some of the dependencies
  • resolves the envs

Happy to hear any other things we could capture in the process (short of automating release, which isn't that important just yet).

Out of scope is going to a reproducible build system (e.g. flit) as there's no good solution for the packaging jumping jacks required for #6... might renew a push (several levels) upstream on this, as it concerns me.

@nrbgt nrbgt changed the title [wip] 0.2.0 postmortem [wip] 0.2.0 postmortem 🪦 Nov 12, 2020
@nrbgt nrbgt changed the title [wip] 0.2.0 postmortem 🪦 [wip] 0.2.0 postmortem ☠️ Nov 12, 2020
@nrbgt nrbgt changed the title [wip] 0.2.0 postmortem ☠️ 0.2.0 postmortem ☠️ Nov 12, 2020
@nrbgt nrbgt added this to In progress in Planning Nov 12, 2020
Copy link
Contributor

@dfreeman06 dfreeman06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch on the dangling ipyelk/tools/__init__.py. I was confused for too long when i saw in the PR that the file was deleted.

@dfreeman06 dfreeman06 merged commit 962da77 into jupyrdf:master Nov 13, 2020
@nrbgt nrbgt moved this from In progress to Done in Planning Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants