Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ci to verify docker build is reliable #793

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

devstein
Copy link
Collaborator

Description

We want new users to be able to reliably build the Sparkmagic example Docker images. Right now, we have no integration tests using the Docker images, so the only failures are reported by users.

This adds CI to ensure the Docker image always builds. In the future, we can add CI to actually run the images and run integration tests against it.

Relates to #789 and #791

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

@devstein devstein self-assigned this Dec 30, 2022
@devstein devstein merged commit 52d1e45 into master Dec 30, 2022
@devstein devstein deleted the devstein/add-docker-build-ci branch December 30, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant